[Impala-ASF-CR] IMPALA-9865: part 2/2: add verbosity to profile tool

["Joe McDonnell (Code Review)" <ge...@cloudera.org>]

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16881 )

Change subject: IMPALA-9865: part 2/2: add verbosity to profile tool
......................................................................


Patch Set 8: Code-Review+2

(1 comment)

This makes sense to me. Thanks for adding the test for the profile output.

http://gerrit.cloudera.org:8080/#/c/16881/8/be/src/util/runtime-profile.h
File be/src/util/runtime-profile.h:

http://gerrit.cloudera.org:8080/#/c/16881/8/be/src/util/runtime-profile.h@177
PS8, Line 177:   void PrettyPrint(std::ostream* s, const std::string& prefix = "") const;
For my understanding, what type of code uses this overload that doesn't take in the verbosity?



-- 
To view, visit http://gerrit.cloudera.org:8080/16881
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82618a813e29af7996dfaed78873b2a73bc0231d
Gerrit-Change-Number: 16881
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jan 2021 18:05:26 +0000
Gerrit-HasComments: Yes