You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/05/16 15:17:01 UTC
[jira] [Work logged] (HDDS-1065) OM and DN should persist SCM
certificate as the trust root.
[ https://issues.apache.org/jira/browse/HDDS-1065?focusedWorklogId=243398&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-243398 ]
ASF GitHub Bot logged work on HDDS-1065:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/19 15:16
Start Date: 16/May/19 15:16
Worklog Time Spent: 10m
Work Description: anuengineer commented on pull request #754: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar.
URL: https://github.com/apache/hadoop/pull/754#discussion_r284760860
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/CertificateClient.java
##########
@@ -135,10 +135,11 @@ boolean verifySignature(byte[] data, byte[] signature,
*
* @param pemEncodedCert - pem encoded X509 Certificate
* @param force - override any existing file
+ * @param caCert - Is CA certificate.
* @throws CertificateException - on Error.
*
*/
- void storeCertificate(String pemEncodedCert, boolean force)
+ void storeCertificate(String pemEncodedCert, boolean force, boolean caCert)
Review comment:
Why don't you write a new function, called storeRootCertificate. That avoids adding this false argument to lots of other parts of the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 243398)
Time Spent: 1h 20m (was: 1h 10m)
> OM and DN should persist SCM certificate as the trust root.
> -----------------------------------------------------------
>
> Key: HDDS-1065
> URL: https://issues.apache.org/jira/browse/HDDS-1065
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> OM and DN should persist SCM certificate as the trust root.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org