[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6300: NIFI-9374 Add Standard Deprecation Logger

[GitBox <gi...@apache.org>]

exceptionfactory commented on code in PR #6300:
URL: https://github.com/apache/nifi/pull/6300#discussion_r948372681


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/logback.xml:
##########
@@ -88,6 +88,17 @@
         </encoder>
     </appender>
 
+    <appender name="DEPRECATION_FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
+        <file>${org.apache.nifi.bootstrap.config.log.dir}/nifi-deprecation.log</file>
+        <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy">
+            <fileNamePattern>${org.apache.nifi.bootstrap.config.log.dir}/nifi-deprecation_%d.log</fileNamePattern>
+            <maxHistory>30</maxHistory>
+        </rollingPolicy>
+        <encoder class="ch.qos.logback.classic.encoder.PatternLayoutEncoder">
+            <pattern>%date %level [%thread] %logger %msg%n</pattern>

Review Comment:
   The logger name is not truncated in this specific scenario because it is important to know the exact class name containing deprecated references.
   
   Under optimal circumstances, the nifi-deprecation.log will be empty, but when a deployment includes deprecated components or features, the logger name and associated stack trace will provide a reference to component usage that needs to be changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org