[GitHub] [spark] srowen commented on a diff in pull request #43129: no-java-comments

["srowen (via GitHub)" <gi...@apache.org>]

srowen commented on code in PR #43129:
URL: https://github.com/apache/spark/pull/43129#discussion_r1337216539


##########
project/SparkBuild.scala:
##########
@@ -358,7 +358,7 @@ object SparkBuild extends PomBuild {
       "-doc-title", "Spark " + version.value.replaceAll("-SNAPSHOT", "") + " ScalaDoc"
     ) ++ {
       // Do not attempt to scaladoc javadoc comments under 2.12 since it can't handle inner classes
-      if (scalaBinaryVersion.value == "2.12") Seq("-no-java-comments") else Seq.empty
+      if (scalaBinaryVersion.value == "2.13") Seq("-no-java-comments") else Seq.empty

Review Comment:
   I think you should just remove this part, right? does not apply in Scala 2.13



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org