You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by ho...@apache.org on 2024/05/28 03:11:23 UTC
(incubator-gluten) branch main updated: [VL] Following #5861, append some nit changes
This is an automated email from the ASF dual-hosted git repository.
hongze pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 12fdb7029 [VL] Following #5861, append some nit changes
12fdb7029 is described below
commit 12fdb7029a4921ff035c8a979c1580447d0acb72
Author: Hongze Zhang <ho...@intel.com>
AuthorDate: Tue May 28 11:11:19 2024 +0800
[VL] Following #5861, append some nit changes
---
.../apache/gluten/extension/columnar/enumerated/RemoveFilter.scala | 4 ++--
.../main/scala/org/apache/gluten/planner/cost/GlutenCostModel.scala | 2 +-
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gluten-core/src/main/scala/org/apache/gluten/extension/columnar/enumerated/RemoveFilter.scala b/gluten-core/src/main/scala/org/apache/gluten/extension/columnar/enumerated/RemoveFilter.scala
index a3b4831a6..55b29cd56 100644
--- a/gluten-core/src/main/scala/org/apache/gluten/extension/columnar/enumerated/RemoveFilter.scala
+++ b/gluten-core/src/main/scala/org/apache/gluten/extension/columnar/enumerated/RemoveFilter.scala
@@ -54,12 +54,12 @@ object RemoveFilter extends RasRule[SparkPlan] {
leaf(clazz(classOf[BasicScanExecTransformer]))
).build())
- // A noop filter placeholder that indicates that all conditions are pushed into scan.
+ // A noop filter placeholder that indicates that all conditions are pushed down to scan.
//
// This operator has zero cost in cost model to avoid planner from choosing the
// original filter-scan that doesn't have all conditions pushed down to scan.
//
- // We cannot simplify remove the filter to let planner choose the scan since by vanilla
+ // We cannot simply remove the filter to let planner choose the pushed scan since by vanilla
// Spark's definition the filter may have different output nullability than scan. So
// we have to keep this empty filter to let the optimized tree have the identical output schema
// with the original tree. If we simply remove the filter, possible UBs might be caused. For
diff --git a/gluten-core/src/main/scala/org/apache/gluten/planner/cost/GlutenCostModel.scala b/gluten-core/src/main/scala/org/apache/gluten/planner/cost/GlutenCostModel.scala
index 4b5fa6803..c45314a9f 100644
--- a/gluten-core/src/main/scala/org/apache/gluten/planner/cost/GlutenCostModel.scala
+++ b/gluten-core/src/main/scala/org/apache/gluten/planner/cost/GlutenCostModel.scala
@@ -80,7 +80,7 @@ object GlutenCostModel extends Logging {
// by vanilla Spark and was generated by strategy "JoinSelectionOverrides"
infLongCost
case _: RemoveFilter.NoopFilter =>
- // To make planner choose the tree that has applied rule PushFilterToScan.
+ // To make planner choose the tree that has applied rule PushFilterToScan.
0L
case ColumnarToRowExec(child) => 3L
case RowToColumnarExec(child) => 3L
diff --git a/shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala b/shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
index 9db063a66..d353c75c3 100644
--- a/shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
+++ b/shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
@@ -1209,7 +1209,7 @@ object GlutenConfig {
val RAS_COST_MODEL =
buildConf("spark.gluten.ras.costModel")
.doc(
- "Experimental: The classpath of user-defined cost model that will be used by RAS. " +
+ "Experimental: The class name of user-defined cost model that will be used by RAS. " +
"If not specified, a rough built-in cost model will be used.")
.stringConf
.createWithDefaultString("rough")
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org