You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tedyu <gi...@git.apache.org> on 2015/09/03 16:12:57 UTC
[GitHub] flink pull request: FLINK-2605 Unclosed RandomAccessFile may leak ...
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/1089
FLINK-2605 Unclosed RandomAccessFile may leak resource in StaticFileS…
…erverHandler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedyu/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1089.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1089
----
commit d900be453f9ebac68bcf7e4c75b8d80d0fa8b2c5
Author: tedyu <yu...@gmail.com>
Date: 2015-09-03T14:11:32Z
FLINK-2605 Unclosed RandomAccessFile may leak resource in StaticFileServerHandler
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-2605 Unclosed RandomAccessFile may leak ...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1089#issuecomment-137761664
Thanks for the PR. The change looks good. It is good to merge.
The following comment is optional to address: I understand that you didn't add the last two statements to the catch block as they don't depend on the `RandomAccessFile`, but I think it increases readability if they are part of it. What do you think about this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-2605 Unclosed RandomAccessFile may leak ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1089
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-2605 Unclosed RandomAccessFile may leak ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1089#issuecomment-137837300
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-2605 Unclosed RandomAccessFile may leak ...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1089#issuecomment-137923702
+1
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-2605 Unclosed RandomAccessFile may leak ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1089#issuecomment-137857005
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-2605 Unclosed RandomAccessFile may leak ...
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu commented on the pull request:
https://github.com/apache/flink/pull/1089#issuecomment-137772269
Your reasoning w.r.t. current scope of try block was the same as mine.
I think it is good to make the scope as accurate as possible. Generally speaking, we don't want to react to unrelated exception.
Please keep the current formation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---