You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/06 08:24:20 UTC

[GitHub] [spark] ConeyLiu commented on a change in pull request #24278: [SPARK-27350][SQL] Support create table on data source V2

ConeyLiu commented on a change in pull request #24278: [SPARK-27350][SQL] Support create table on data source V2
URL: https://github.com/apache/spark/pull/24278#discussion_r281097413
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala
 ##########
 @@ -53,25 +50,6 @@ case class DataSourceResolution(conf: SQLConf) extends Rule[LogicalPlan] with Ca
       CreateTable(tableDesc, mode, Some(query))
   }
 
-  object V1WriteProvider {
-    private val v1WriteOverrideSet =
 
 Review comment:
   The `V1WriteProvider` will remove the provider message when it is v2 source. And the checking is done in the command.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org