[PR] RANGER-5688: maven-source-plugin.version property is referenced but never defined [ranger]

["magnuma3 (via GitHub)" <gi...@apache.org>]

magnuma3 opened a new pull request, #1074:
URL: https://github.com/apache/ranger/pull/1074

   ## What changes were proposed in this pull request?
   
   (Please fill in changes proposed in this fix. Create an issue in ASF JIRA before opening a pull request and
   set the title of the pull request which starts with
   the corresponding JIRA issue number. (e.g. RANGER-XXXX: Fix a typo in YYY))
   
   RANGER-4076 replaced the hardcoded maven-source-plugin version in the root pom's pluginManagement with a property reference, but the property was never defined:
   
   ```xml
   <plugin>
   <groupId>org.apache.maven.plugins</groupId>
   <artifactId>maven-source-plugin</artifactId>
   <version>${maven-source-plugin.version}</version>
   ```
   
   git grep '<maven-source-plugin.version>' returns nothing.
   
   Since pluginManagement entries are only resolved when the plugin is actually invoked, normal builds are unaffected. But any invocation of the plugin by prefix, e.g.:
   
   ```
   mvn install source:jar
   ```
   
   fails at startup, because the undefined property survives as a literal and Maven tries to resolve version ${maven-source-plugin.version} from central:
   
   ```
   [ERROR] Plugin org.apache.maven.plugins:maven-source-plugin:${maven-source-plugin.version} or one of its dependencies could not be resolved
   ```
   
   Fix: define the property alongside the other plugin versions in the root pom, e.g. <maven-source-plugin.version>3.3.1</maven-source-plugin.version>.
   
   
   ## How was this patch tested?
   
   (Please explain how this patch was tested. Ex: unit tests, manual tests)
   (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org