You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "DomGarguilo (via GitHub)" <gi...@apache.org> on 2023/09/08 18:49:33 UTC
[GitHub] [accumulo-docker] DomGarguilo opened a new pull request, #30: Bump accumulo, zookeeper, hadoop versions
DomGarguilo opened a new pull request, #30:
URL: https://github.com/apache/accumulo-docker/pull/30
Bump hadoop from 3.3.4 -> 3.3.6
Bump zookeeper from 3.8.0 -> 3.8.2
Bump accumulo from 2.1.0 -> 2.1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-docker] ctubbsii commented on a diff in pull request #30: Bump accumulo, zookeeper, hadoop versions
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #30:
URL: https://github.com/apache/accumulo-docker/pull/30#discussion_r1320670351
##########
README.md:
##########
@@ -39,7 +39,7 @@ building an image:
Or build with an Accumulo tarball (located in same directory as DockerFile) using the command below:
- docker build --build-arg ACCUMULO_FILE=accumulo-2.1.0-SNAPSHOT-bin.tar.gz -t accumulo .
+ docker build --build-arg ACCUMULO_FILE=accumulo-2.1.2-SNAPSHOT-bin.tar.gz -t accumulo .
Review Comment:
Since this is just an example, it doesn't need to be updated every time.
```suggestion
docker build --build-arg ACCUMULO_FILE=accumulo-*-bin.tar.gz -t accumulo .
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-docker] DomGarguilo commented on a diff in pull request #30: Bump accumulo, zookeeper, hadoop versions
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on code in PR #30:
URL: https://github.com/apache/accumulo-docker/pull/30#discussion_r1321848241
##########
README.md:
##########
@@ -39,7 +39,7 @@ building an image:
Or build with an Accumulo tarball (located in same directory as DockerFile) using the command below:
- docker build --build-arg ACCUMULO_FILE=accumulo-2.1.0-SNAPSHOT-bin.tar.gz -t accumulo .
+ docker build --build-arg ACCUMULO_FILE=accumulo-2.1.2-SNAPSHOT-bin.tar.gz -t accumulo .
Review Comment:
what about replacing `*` with `<version>` in your suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-docker] DomGarguilo commented on a diff in pull request #30: Bump accumulo, zookeeper, hadoop versions
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on code in PR #30:
URL: https://github.com/apache/accumulo-docker/pull/30#discussion_r1334761295
##########
README.md:
##########
@@ -39,7 +39,7 @@ building an image:
Or build with an Accumulo tarball (located in same directory as DockerFile) using the command below:
- docker build --build-arg ACCUMULO_FILE=accumulo-2.1.0-SNAPSHOT-bin.tar.gz -t accumulo .
+ docker build --build-arg ACCUMULO_FILE=accumulo-2.1.2-SNAPSHOT-bin.tar.gz -t accumulo .
Review Comment:
Addressed in 9930f8e. Also, unrelated, I added `json` to a code block in the readme for better markdown styling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-docker] DomGarguilo merged pull request #30: Bump accumulo, zookeeper, hadoop versions
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo merged PR #30:
URL: https://github.com/apache/accumulo-docker/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-docker] ctubbsii commented on a diff in pull request #30: Bump accumulo, zookeeper, hadoop versions
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #30:
URL: https://github.com/apache/accumulo-docker/pull/30#discussion_r1321897480
##########
README.md:
##########
@@ -39,7 +39,7 @@ building an image:
Or build with an Accumulo tarball (located in same directory as DockerFile) using the command below:
- docker build --build-arg ACCUMULO_FILE=accumulo-2.1.0-SNAPSHOT-bin.tar.gz -t accumulo .
+ docker build --build-arg ACCUMULO_FILE=accumulo-2.1.2-SNAPSHOT-bin.tar.gz -t accumulo .
Review Comment:
That's fine, or something like `/path/to/accumulo-<version>-bin.tar.gz`
The main thing is that it should either be something that somebody can copy/paste directly (with `*`, that should work), or it should be very obvious what parts they need to edit (which `<version>` would provide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org