You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2015/07/18 21:11:41 UTC
spark git commit: [SPARK-9151][SQL] Implement code generation for Abs
Repository: spark
Updated Branches:
refs/heads/master 86c50bf72 -> 225de8da2
[SPARK-9151][SQL] Implement code generation for Abs
JIRA: https://issues.apache.org/jira/browse/SPARK-9151
Add codegen support for `Abs`.
Author: Liang-Chi Hsieh <vi...@appier.com>
Closes #7498 from viirya/abs_codegen and squashes the following commits:
0c8410f [Liang-Chi Hsieh] Implement code generation for Abs.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/225de8da
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/225de8da
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/225de8da
Branch: refs/heads/master
Commit: 225de8da2b20ba03b358e222411610e8567aa88d
Parents: 86c50bf
Author: Liang-Chi Hsieh <vi...@appier.com>
Authored: Sat Jul 18 12:11:37 2015 -0700
Committer: Reynold Xin <rx...@databricks.com>
Committed: Sat Jul 18 12:11:37 2015 -0700
----------------------------------------------------------------------
.../apache/spark/sql/catalyst/expressions/arithmetic.scala | 7 +++++++
.../src/main/scala/org/apache/spark/sql/types/Decimal.scala | 2 ++
2 files changed, 9 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/225de8da/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
index c5960eb..e83650f 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
@@ -73,6 +73,13 @@ case class Abs(child: Expression) extends UnaryExpression with ExpectsInputTypes
private lazy val numeric = TypeUtils.getNumeric(dataType)
+ override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): String = dataType match {
+ case dt: DecimalType =>
+ defineCodeGen(ctx, ev, c => s"$c.abs()")
+ case dt: NumericType =>
+ defineCodeGen(ctx, ev, c => s"(${ctx.javaType(dt)})(java.lang.Math.abs($c))")
+ }
+
protected override def nullSafeEval(input: Any): Any = numeric.abs(input)
}
http://git-wip-us.apache.org/repos/asf/spark/blob/225de8da/sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
index a85af9e..bc68981 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
@@ -278,6 +278,8 @@ final class Decimal extends Ordered[Decimal] with Serializable {
Decimal(-longVal, precision, scale)
}
}
+
+ def abs: Decimal = if (this.compare(Decimal(0)) < 0) this.unary_- else this
}
object Decimal {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org