You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by be...@apache.org on 2006/07/11 19:06:51 UTC
svn commit: r420926 -
/james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java
Author: berndf
Date: Tue Jul 11 10:06:50 2006
New Revision: 420926
URL: http://svn.apache.org/viewvc?rev=420926&view=rev
Log:
- remove repeated configuration, since it is redundant, see line #155 (origin of this now reverted change: see JAMES-477, compare revisions 392227 and 394291 of this class)
Modified:
james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java
Modified: james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java
URL: http://svn.apache.org/viewvc/james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java?rev=420926&r1=420925&r2=420926&view=diff
==============================================================================
--- james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java (original)
+++ james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java Tue Jul 11 10:06:50 2006
@@ -218,8 +218,6 @@
heloEhloEnforcement = handlerConfiguration.getChild("heloEhloEnforcement").getValueAsBoolean(true);
- if (authRequiredString.equals("true")) authRequired = AUTH_REQUIRED;
-
// get the smtpGreeting
smtpGreeting = handlerConfiguration.getChild("smtpGreeting").getValue(null);
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: svn commit: r420926 - /james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java
Posted by Bernd Fondermann <bf...@brainlounge.de>.
Thanks for the quick response!
Stefano Bagnara wrote:
> Bernd Fondermann wrote:
>
> Your fix makes sense to me.
> I agree that line was probably there by mistake.
>
> I think we should backport this to 2.3 branch (I verified the same wrong
> line is there too) for the next release.
Just needed it removed for extracting above block as a method on its own.
It does no harm, it's not a bug, so no need to backport from my point of
view.
Bernd
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: svn commit: r420926 - /james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java
Posted by Stefano Bagnara <ap...@bago.org>.
Bernd Fondermann wrote:
> Norman (original contributor), Stefano (original committer) could you
> please check that I did not get something wrong here. I think the line
> slipped in unintendedly.
Your fix makes sense to me.
I agree that line was probably there by mistake.
I think we should backport this to 2.3 branch (I verified the same wrong
line is there too) for the next release.
Thank you,
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: svn commit: r420926 - /james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java
Posted by Bernd Fondermann <bf...@brainlounge.de>.
Norman (original contributor), Stefano (original committer) could you
please check that I did not get something wrong here. I think the line
slipped in unintendedly.
Thank you!
Bernd
berndf@apache.org wrote:
> Author: berndf
> Date: Tue Jul 11 10:06:50 2006
> New Revision: 420926
>
> URL: http://svn.apache.org/viewvc?rev=420926&view=rev
> Log:
> - remove repeated configuration, since it is redundant, see line #155 (origin of this now reverted change: see JAMES-477, compare revisions 392227 and 394291 of this class)
>
> Modified:
> james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java
>
> Modified: james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java
> URL: http://svn.apache.org/viewvc/james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java?rev=420926&r1=420925&r2=420926&view=diff
> ==============================================================================
> --- james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java (original)
> +++ james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java Tue Jul 11 10:06:50 2006
> @@ -218,8 +218,6 @@
>
> heloEhloEnforcement = handlerConfiguration.getChild("heloEhloEnforcement").getValueAsBoolean(true);
>
> - if (authRequiredString.equals("true")) authRequired = AUTH_REQUIRED;
> -
> // get the smtpGreeting
> smtpGreeting = handlerConfiguration.getChild("smtpGreeting").getValue(null);
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: svn commit: r420926 -
/james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java
Posted by Norman Maurer <nm...@byteaction.de>.
Yeah that should be a failure of mine ..just remove it ;-)
thx
Norman
Am Dienstag, den 11.07.2006, 19:11 +0200 schrieb Bernd Fondermann:
> Norman (original contributor), Stefano (original committer) could you
> please check that I did not get something wrong here. I think the line
> slipped in unintendedly.
>
> Thank you!
>
> Bernd
>
> berndf@apache.org wrote:
> > Author: berndf
> > Date: Tue Jul 11 10:06:50 2006
> > New Revision: 420926
> >
> > URL: http://svn.apache.org/viewvc?rev=420926&view=rev
> > Log:
> > - remove repeated configuration, since it is redundant, see line #155 (origin of this now reverted change: see JAMES-477, compare revisions 392227 and 394291 of this class)
> >
> > Modified:
> > james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java
> >
> > Modified: james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java
> > URL: http://svn.apache.org/viewvc/james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java?rev=420926&r1=420925&r2=420926&view=diff
> > ==============================================================================
> > --- james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java (original)
> > +++ james/server/trunk/src/java/org/apache/james/smtpserver/SMTPServer.java Tue Jul 11 10:06:50 2006
> > @@ -218,8 +218,6 @@
> >
> > heloEhloEnforcement = handlerConfiguration.getChild("heloEhloEnforcement").getValueAsBoolean(true);
> >
> > - if (authRequiredString.equals("true")) authRequired = AUTH_REQUIRED;
> > -
> > // get the smtpGreeting
> > smtpGreeting = handlerConfiguration.getChild("smtpGreeting").getValue(null);
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> > For additional commands, e-mail: server-dev-help@james.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
> !EXCUBATOR:1,44b3db9743762240618380!