You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by ff...@apache.org on 2014/05/15 12:42:01 UTC

git commit: [KARAF-2980]strip off tabs/spaces around role|group names

Repository: karaf
Updated Branches:
  refs/heads/karaf-2.x f5bf62cdc -> a27ef6cd3


[KARAF-2980]strip off tabs/spaces around role|group names


Project: http://git-wip-us.apache.org/repos/asf/karaf/repo
Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/a27ef6cd
Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/a27ef6cd
Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/a27ef6cd

Branch: refs/heads/karaf-2.x
Commit: a27ef6cd32d84a999bbe601b835192fde4516dca
Parents: f5bf62c
Author: Freeman Fang <fr...@gmail.com>
Authored: Thu May 15 18:41:36 2014 +0800
Committer: Freeman Fang <fr...@gmail.com>
Committed: Thu May 15 18:41:36 2014 +0800

----------------------------------------------------------------------
 .../jaas/modules/properties/PropertiesLoginModule.java    | 10 +++++-----
 .../jaas/modules/publickey/PublickeyLoginModule.java      | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/karaf/blob/a27ef6cd/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java
----------------------------------------------------------------------
diff --git a/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java b/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java
index 0bc983a..67c8986 100644
--- a/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java
+++ b/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java
@@ -148,19 +148,19 @@ public class PropertiesLoginModule extends AbstractKarafLoginModule {
         principals = new HashSet<Principal>();
         principals.add(new UserPrincipal(user));
         for (int i = 1; i < infos.length; i++) {
-            if (infos[i].startsWith(PropertiesBackingEngine.GROUP_PREFIX)) {
+            if (infos[i].trim().startsWith(PropertiesBackingEngine.GROUP_PREFIX)) {
                 // it's a group reference
-                principals.add(new GroupPrincipal(infos[i].substring(PropertiesBackingEngine.GROUP_PREFIX.length())));
-                String groupInfo = (String) users.get(infos[i]);
+                principals.add(new GroupPrincipal(infos[i].trim().substring(PropertiesBackingEngine.GROUP_PREFIX.length())));
+                String groupInfo = (String) users.get(infos[i].trim());
                 if (groupInfo != null) {
                     String[] roles = groupInfo.split(",");
                     for (int j = 1; j < roles.length; j++) {
-                        principals.add(new RolePrincipal(roles[j]));
+                        principals.add(new RolePrincipal(roles[j].trim()));
                     }
                 }
             } else {
                 // it's an user reference
-                principals.add(new RolePrincipal(infos[i]));
+                principals.add(new RolePrincipal(infos[i].trim()));
             }
         }
 

http://git-wip-us.apache.org/repos/asf/karaf/blob/a27ef6cd/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/publickey/PublickeyLoginModule.java
----------------------------------------------------------------------
diff --git a/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/publickey/PublickeyLoginModule.java b/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/publickey/PublickeyLoginModule.java
index e6bcad1..2a20329 100644
--- a/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/publickey/PublickeyLoginModule.java
+++ b/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/publickey/PublickeyLoginModule.java
@@ -122,19 +122,19 @@ public class PublickeyLoginModule extends AbstractKarafLoginModule {
         principals = new HashSet<Principal>();
         principals.add(new UserPrincipal(user));
         for (int i = 1; i < infos.length; i++) {
-            if (infos[i].startsWith(PropertiesBackingEngine.GROUP_PREFIX)) {
+            if (infos[i].trim().startsWith(PropertiesBackingEngine.GROUP_PREFIX)) {
                 // it's a group reference
-                principals.add(new GroupPrincipal(infos[i].substring(PropertiesBackingEngine.GROUP_PREFIX.length())));
-                String groupInfo = (String) users.get(infos[i]);
+                principals.add(new GroupPrincipal(infos[i].trim().substring(PropertiesBackingEngine.GROUP_PREFIX.length())));
+                String groupInfo = (String) users.get(infos[i].trim());
                 if (groupInfo != null) {
                     String[] roles = groupInfo.split(",");
                     for (int j = 1; j < roles.length; j++) {
-                        principals.add(new RolePrincipal(roles[j]));
+                        principals.add(new RolePrincipal(roles[j].trim()));
                     }
                 }
             } else {
                 // it's an user reference
-                principals.add(new RolePrincipal(infos[i]));
+                principals.add(new RolePrincipal(infos[i].trim()));
             }
         }