You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org> on 2010/01/24 04:21:17 UTC
[jira] Created: (AVRO-374) After a fresh 'build.sh test' svn
reports certain files modified in Ubuntu 9.10
After a fresh 'build.sh test' svn reports certain files modified in Ubuntu 9.10
-------------------------------------------------------------------------------
Key: AVRO-374
URL: https://issues.apache.org/jira/browse/AVRO-374
Project: Avro
Issue Type: Bug
Components: c++
Reporter: Thiruvalluvan M. G.
Priority: Minor
After fresh checkout and a "build.sh test", svn says certain C++ related files as modified:
{code}
M lang/c++/configure
M lang/c++/Makefile.in
M lang/c++/config/depcomp
M lang/c++/config/missing
M lang/c++/config/config.guess
M lang/c++/config/config.sub
M lang/c++/config/ltmain.sh
M lang/c++/config/install-sh
M lang/c++/config/ylwrap
M lang/c++/INSTALL
M lang/c++/aclocal.m4
{code}
It appears that these files are generated during the build and they are platform-dependent. If so, they should not be checked in to svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-374) After a fresh 'build.sh test' svn
reports certain files modified in Ubuntu 9.10
Posted by "Scott Banachowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Banachowski updated AVRO-374:
-----------------------------------
Attachment: ignore374
applypatch374.sh
AVRO-374.patch
To apply patch, put all three files in the root directory, then run the applypatch374.sh script
> After a fresh 'build.sh test' svn reports certain files modified in Ubuntu 9.10
> -------------------------------------------------------------------------------
>
> Key: AVRO-374
> URL: https://issues.apache.org/jira/browse/AVRO-374
> Project: Avro
> Issue Type: Bug
> Components: c++
> Reporter: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: applypatch374.sh, AVRO-374.patch, ignore374
>
>
> After fresh checkout and a "build.sh test", svn says certain C++ related files as modified:
> {code}
> M lang/c++/configure
> M lang/c++/Makefile.in
> M lang/c++/config/depcomp
> M lang/c++/config/missing
> M lang/c++/config/config.guess
> M lang/c++/config/config.sub
> M lang/c++/config/ltmain.sh
> M lang/c++/config/install-sh
> M lang/c++/config/ylwrap
> M lang/c++/INSTALL
> M lang/c++/aclocal.m4
> {code}
> It appears that these files are generated during the build and they are platform-dependent. If so, they should not be checked in to svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-374) After a fresh 'build.sh test' svn
reports certain files modified in Ubuntu 9.10
Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804784#action_12804784 ]
Matt Massie commented on AVRO-374:
----------------------------------
I would advise that you only check in your Makefile.am and configure.in files. We should svn/git ignore all the autogenerated files since they will vary based on the version of autotools installed on the host building Avro C++.
To build a distributable tarball,
$ cd lang/c++
$ autoreconf -f -i
$ ./configure && make distcheck
should do that trick. The 'distcheck' target will do a VPATH build of Avro C++ and all it's test. If all tests succeed, it will create a distributable tarball with all the files people will need to successfully build Avro C++. It would be best if we use the same machine to create the tarball or at least machines with the same version of autotools.
> After a fresh 'build.sh test' svn reports certain files modified in Ubuntu 9.10
> -------------------------------------------------------------------------------
>
> Key: AVRO-374
> URL: https://issues.apache.org/jira/browse/AVRO-374
> Project: Avro
> Issue Type: Bug
> Components: c++
> Reporter: Thiruvalluvan M. G.
> Priority: Minor
>
> After fresh checkout and a "build.sh test", svn says certain C++ related files as modified:
> {code}
> M lang/c++/configure
> M lang/c++/Makefile.in
> M lang/c++/config/depcomp
> M lang/c++/config/missing
> M lang/c++/config/config.guess
> M lang/c++/config/config.sub
> M lang/c++/config/ltmain.sh
> M lang/c++/config/install-sh
> M lang/c++/config/ylwrap
> M lang/c++/INSTALL
> M lang/c++/aclocal.m4
> {code}
> It appears that these files are generated during the build and they are platform-dependent. If so, they should not be checked in to svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-374) After a fresh 'build.sh test' svn
reports certain files modified in Ubuntu 9.10
Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804674#action_12804674 ]
Thiruvalluvan M. G. commented on AVRO-374:
------------------------------------------
Maybe I'm missing something. If autoreconf is going to always generate (or copy) these files, can we not drop them from svn?
> After a fresh 'build.sh test' svn reports certain files modified in Ubuntu 9.10
> -------------------------------------------------------------------------------
>
> Key: AVRO-374
> URL: https://issues.apache.org/jira/browse/AVRO-374
> Project: Avro
> Issue Type: Bug
> Components: c++
> Reporter: Thiruvalluvan M. G.
> Priority: Minor
>
> After fresh checkout and a "build.sh test", svn says certain C++ related files as modified:
> {code}
> M lang/c++/configure
> M lang/c++/Makefile.in
> M lang/c++/config/depcomp
> M lang/c++/config/missing
> M lang/c++/config/config.guess
> M lang/c++/config/config.sub
> M lang/c++/config/ltmain.sh
> M lang/c++/config/install-sh
> M lang/c++/config/ylwrap
> M lang/c++/INSTALL
> M lang/c++/aclocal.m4
> {code}
> It appears that these files are generated during the build and they are platform-dependent. If so, they should not be checked in to svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-374) After a fresh 'build.sh test' svn
reports certain files modified in Ubuntu 9.10
Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833358#action_12833358 ]
Thiruvalluvan M. G. commented on AVRO-374:
------------------------------------------
+1
Verified that the patch works in both cygwin and Ubuntu 9.10.
It'll be nice if we can make svn ignore these files:
lang/c++/m4/ltsugar.m4
lang/c++/m4/libtool.m4
lang/c++/m4/ltversion.m4
lang/c++/m4/lt~obsolete.m4
lang/c++/m4/ltoptions.m4
Thanks Scott.
> After a fresh 'build.sh test' svn reports certain files modified in Ubuntu 9.10
> -------------------------------------------------------------------------------
>
> Key: AVRO-374
> URL: https://issues.apache.org/jira/browse/AVRO-374
> Project: Avro
> Issue Type: Bug
> Components: c++
> Reporter: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: applypatch374.sh, AVRO-374.patch, ignore374
>
>
> After fresh checkout and a "build.sh test", svn says certain C++ related files as modified:
> {code}
> M lang/c++/configure
> M lang/c++/Makefile.in
> M lang/c++/config/depcomp
> M lang/c++/config/missing
> M lang/c++/config/config.guess
> M lang/c++/config/config.sub
> M lang/c++/config/ltmain.sh
> M lang/c++/config/install-sh
> M lang/c++/config/ylwrap
> M lang/c++/INSTALL
> M lang/c++/aclocal.m4
> {code}
> It appears that these files are generated during the build and they are platform-dependent. If so, they should not be checked in to svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-374) After a fresh 'build.sh test' svn
reports certain files modified in Ubuntu 9.10
Posted by "Scott Banachowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804650#action_12804650 ]
Scott Banachowski commented on AVRO-374:
----------------------------------------
Hmm, as I suspected the warnings cannot be ignored, as the build fails on cygwin without the autoreconf step (it spits out errors about incompatible autoconf).
If modifying those files is really a problem, what I can try is to let the build.sh script run configure + make, and if it fails, then try autoreconf + configure + make. This way, it would only effect a subset of people.
Another way would be to copy the whole source tree to build, and then only modify the copy.
Maybe the latter is the preferred approach?
> After a fresh 'build.sh test' svn reports certain files modified in Ubuntu 9.10
> -------------------------------------------------------------------------------
>
> Key: AVRO-374
> URL: https://issues.apache.org/jira/browse/AVRO-374
> Project: Avro
> Issue Type: Bug
> Components: c++
> Reporter: Thiruvalluvan M. G.
> Priority: Minor
>
> After fresh checkout and a "build.sh test", svn says certain C++ related files as modified:
> {code}
> M lang/c++/configure
> M lang/c++/Makefile.in
> M lang/c++/config/depcomp
> M lang/c++/config/missing
> M lang/c++/config/config.guess
> M lang/c++/config/config.sub
> M lang/c++/config/ltmain.sh
> M lang/c++/config/install-sh
> M lang/c++/config/ylwrap
> M lang/c++/INSTALL
> M lang/c++/aclocal.m4
> {code}
> It appears that these files are generated during the build and they are platform-dependent. If so, they should not be checked in to svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-374) After a fresh 'build.sh test' svn
reports certain files modified in Ubuntu 9.10
Posted by "Scott Banachowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804755#action_12804755 ]
Scott Banachowski commented on AVRO-374:
----------------------------------------
Typically, a user should be able to start with configure, and so those files are usually bundled in a distribution package. Only a maintainer should have to run a command to generate those files. If we take the view that a top-level avro build is a done by a maintainer, then leaving those files out of the repository seems reasonable. Otherwise I'd prefer to package them.
Matt knows more about the autotools chain than I. Perhaps he can advise here.
> After a fresh 'build.sh test' svn reports certain files modified in Ubuntu 9.10
> -------------------------------------------------------------------------------
>
> Key: AVRO-374
> URL: https://issues.apache.org/jira/browse/AVRO-374
> Project: Avro
> Issue Type: Bug
> Components: c++
> Reporter: Thiruvalluvan M. G.
> Priority: Minor
>
> After fresh checkout and a "build.sh test", svn says certain C++ related files as modified:
> {code}
> M lang/c++/configure
> M lang/c++/Makefile.in
> M lang/c++/config/depcomp
> M lang/c++/config/missing
> M lang/c++/config/config.guess
> M lang/c++/config/config.sub
> M lang/c++/config/ltmain.sh
> M lang/c++/config/install-sh
> M lang/c++/config/ylwrap
> M lang/c++/INSTALL
> M lang/c++/aclocal.m4
> {code}
> It appears that these files are generated during the build and they are platform-dependent. If so, they should not be checked in to svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-374) After a fresh 'build.sh test' svn
reports certain files modified in Ubuntu 9.10
Posted by "Scott Banachowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804642#action_12804642 ]
Scott Banachowski commented on AVRO-374:
----------------------------------------
Hi Thiru, this is because build.sh is running autoreconf, If your version of autotools is different version than mine, it ends up copying the files from yours into the build directory so the build works.
I think I added this to get around warnings that were being issued by the configure script when run on machines with different versions of autotools. If these warnings don't really break the build, I suppose we can skip running autoreconf and just run configure.
I'll patch that shortly.
> After a fresh 'build.sh test' svn reports certain files modified in Ubuntu 9.10
> -------------------------------------------------------------------------------
>
> Key: AVRO-374
> URL: https://issues.apache.org/jira/browse/AVRO-374
> Project: Avro
> Issue Type: Bug
> Components: c++
> Reporter: Thiruvalluvan M. G.
> Priority: Minor
>
> After fresh checkout and a "build.sh test", svn says certain C++ related files as modified:
> {code}
> M lang/c++/configure
> M lang/c++/Makefile.in
> M lang/c++/config/depcomp
> M lang/c++/config/missing
> M lang/c++/config/config.guess
> M lang/c++/config/config.sub
> M lang/c++/config/ltmain.sh
> M lang/c++/config/install-sh
> M lang/c++/config/ylwrap
> M lang/c++/INSTALL
> M lang/c++/aclocal.m4
> {code}
> It appears that these files are generated during the build and they are platform-dependent. If so, they should not be checked in to svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-374) After a fresh 'build.sh test' svn
reports certain files modified in Ubuntu 9.10
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-374:
------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0
Status: Resolved (was: Patch Available)
> After a fresh 'build.sh test' svn reports certain files modified in Ubuntu 9.10
> -------------------------------------------------------------------------------
>
> Key: AVRO-374
> URL: https://issues.apache.org/jira/browse/AVRO-374
> Project: Avro
> Issue Type: Bug
> Components: c++
> Reporter: Thiruvalluvan M. G.
> Priority: Minor
> Fix For: 1.3.0
>
> Attachments: applypatch374.sh, AVRO-374.patch, ignore374
>
>
> After fresh checkout and a "build.sh test", svn says certain C++ related files as modified:
> {code}
> M lang/c++/configure
> M lang/c++/Makefile.in
> M lang/c++/config/depcomp
> M lang/c++/config/missing
> M lang/c++/config/config.guess
> M lang/c++/config/config.sub
> M lang/c++/config/ltmain.sh
> M lang/c++/config/install-sh
> M lang/c++/config/ylwrap
> M lang/c++/INSTALL
> M lang/c++/aclocal.m4
> {code}
> It appears that these files are generated during the build and they are platform-dependent. If so, they should not be checked in to svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-374) After a fresh 'build.sh test' svn
reports certain files modified in Ubuntu 9.10
Posted by "Scott Banachowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Banachowski updated AVRO-374:
-----------------------------------
Status: Patch Available (was: Open)
> After a fresh 'build.sh test' svn reports certain files modified in Ubuntu 9.10
> -------------------------------------------------------------------------------
>
> Key: AVRO-374
> URL: https://issues.apache.org/jira/browse/AVRO-374
> Project: Avro
> Issue Type: Bug
> Components: c++
> Reporter: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: applypatch374.sh, AVRO-374.patch, ignore374
>
>
> After fresh checkout and a "build.sh test", svn says certain C++ related files as modified:
> {code}
> M lang/c++/configure
> M lang/c++/Makefile.in
> M lang/c++/config/depcomp
> M lang/c++/config/missing
> M lang/c++/config/config.guess
> M lang/c++/config/config.sub
> M lang/c++/config/ltmain.sh
> M lang/c++/config/install-sh
> M lang/c++/config/ylwrap
> M lang/c++/INSTALL
> M lang/c++/aclocal.m4
> {code}
> It appears that these files are generated during the build and they are platform-dependent. If so, they should not be checked in to svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.