You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ivan Zhakov <ch...@gmail.com> on 2005/10/16 08:52:33 UTC
Re: svn commit: r16743 - trunk/subversion/libsvn_wc
On 10/16/05, dionisos@tigris.org <di...@tigris.org> wrote:
> Author: dionisos
> Date: Sun Oct 16 02:12:02 2005
> New Revision: 16743
>
> Modified:
> trunk/subversion/libsvn_wc/adm_ops.c
>
> Log:
> Fix ruby bindings test failure (probably).
>
> * subversion/libsvn_wc/adm_ops.c (revert_admin_things): Fix incorrect log-file
> generation when use-commit-times = yes.
>
>
>
> Modified: trunk/subversion/libsvn_wc/adm_ops.c
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_wc/adm_ops.c?rev=16743&p1=trunk/subversion/libsvn_wc/adm_ops.c&p2=trunk/subversion/libsvn_wc/adm_ops.c&r1=16742&r2=16743
> ==============================================================================
> --- trunk/subversion/libsvn_wc/adm_ops.c (original)
> +++ trunk/subversion/libsvn_wc/adm_ops.c Sun Oct 16 02:12:02 2005
> @@ -1652,7 +1652,7 @@
> SVN_WC__LOG_SET_TIMESTAMP,
> SVN_WC__LOG_ATTR_NAME,
> name,
> - SVN_WC__LOG_ATTR_DEST,
> + SVN_WC__LOG_ATTR_TIMESTAMP,
> svn_time_to_cstring (entry->cmt_date, pool),
> NULL);
>
>
It is my fault. I have copy-pasted and missed to replace, sorry. I was
sleeping when David James caught this. Thanks Erik for fixing it.
--
Ivan Zhakov
Re: svn commit: r16743 - trunk/subversion/libsvn_wc
Posted by Erik Huelsmann <eh...@gmail.com>.
==============================================================================
> > --- trunk/subversion/libsvn_wc/adm_ops.c (original)
> > +++ trunk/subversion/libsvn_wc/adm_ops.c Sun Oct 16 02:12:02 2005
> > @@ -1652,7 +1652,7 @@
> > SVN_WC__LOG_SET_TIMESTAMP,
> > SVN_WC__LOG_ATTR_NAME,
> > name,
> > - SVN_WC__LOG_ATTR_DEST,
> > + SVN_WC__LOG_ATTR_TIMESTAMP,
> > svn_time_to_cstring (entry->cmt_date, pool),
> > NULL);
> >
> >
> It is my fault. I have copy-pasted and missed to replace, sorry. I was
> sleeping when David James caught this. Thanks Erik for fixing it.
Well, don't take it too hard: it only proves my theory that we don't
have enough safety guarantees in libsvn_wc. I'm working now to provide
a libsvn_wc internal API to generate log files. (ie, a series of
svn_wc__loggy_* functions)
bye,
Erik.