You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by mariusneo <gi...@git.apache.org> on 2016/02/27 16:25:51 UTC

[GitHub] lucene-solr pull request: SOLR-8721 Added solr & lucene version to...

GitHub user mariusneo opened a pull request:

    https://github.com/apache/lucene-solr/pull/16

    SOLR-8721 Added solr & lucene version to the response for debug reasons

    Added solr & lucene version to the response of the query handlers for debug purpsoses.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mariusneo/lucene-solr feature/SOLR-8721

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16
    
----
commit 3c4ca8b499c6df68d6c1b1d5fd1300565024ca4d
Author: Marius <ma...@gmail.com>
Date:   2016-02-27T15:23:24Z

    SOLR-8721 Added solr & lucene version to the response of the query handlers for debug purpsoses.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[GitHub] lucene-solr pull request: SOLR-8721 Added solr & lucene version to...

Posted by mariusneo <gi...@git.apache.org>.
Github user mariusneo commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/16#discussion_r54334700
  
    --- Diff: solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java ---
    @@ -177,7 +176,7 @@ public void modifyRequest(ResponseBuilder rb, SearchComponent who, ShardRequest
             }
           }
         } else {
    -      sreq.params.set(CommonParams.DEBUG_QUERY, "false");
    +      sreq.params.set(CommonParams.DEBUG_QUERY, rb.isDebugAll() ? "true" : "false");
    --- End diff --
    
    This may look cumbersome, but it is needed in order to be able pass the "debugQuery" parameter to the shard in case that the query is distributed and doesn't return any results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org