You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "AnonHxy (via GitHub)" <gi...@apache.org> on 2023/08/02 04:03:20 UTC

[GitHub] [bookkeeper] AnonHxy opened a new pull request, #4042: fix AutoCloseableLifecycleComponent close exception log

AnonHxy opened a new pull request, #4042:
URL: https://github.com/apache/bookkeeper/pull/4042

   Descriptions of the changes in this PR:
   
   
   
   ### Motivation
   
   If closed with exception, the log will always be `failed to close AutoCloseableLifecycleComponent`.  It will be better to print the `componentName` instead of the class name.
   
   ### Changes
   
   Print the `componentName` instead of `AutoCloseableLifecycleComponent` class name if closed with exception
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] AnonHxy commented on pull request #4042: fix AutoCloseableLifecycleComponent close exception log

Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on PR #4042:
URL: https://github.com/apache/bookkeeper/pull/4042#issuecomment-1661504328

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] AnonHxy commented on pull request #4042: fix AutoCloseableLifecycleComponent close exception log

Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on PR #4042:
URL: https://github.com/apache/bookkeeper/pull/4042#issuecomment-1670562534

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] AnonHxy commented on pull request #4042: fix AutoCloseableLifecycleComponent close exception log

Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on PR #4042:
URL: https://github.com/apache/bookkeeper/pull/4042#issuecomment-1663215536

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] AnonHxy commented on pull request #4042: fix AutoCloseableLifecycleComponent close exception log

Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on PR #4042:
URL: https://github.com/apache/bookkeeper/pull/4042#issuecomment-1670620481

   > Some other places also need tune.
   > 
   > https://github.com/apache/bookkeeper/blob/3bf08fef12979bf3cff49ee953899f26c6281ad9/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/EmbeddedServer.java#L298
   
   Thanks. Updated. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] AnonHxy commented on pull request #4042: fix AutoCloseableLifecycleComponent close exception log

Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on PR #4042:
URL: https://github.com/apache/bookkeeper/pull/4042#issuecomment-1670563059

   @StevenLuMT @eolivelli @zymap  PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] zymap merged pull request #4042: fix AutoCloseableLifecycleComponent close exception log

Posted by "zymap (via GitHub)" <gi...@apache.org>.
zymap merged PR #4042:
URL: https://github.com/apache/bookkeeper/pull/4042


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org