[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4506: Put Helix manager out of resource manager

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4506: Put Helix manager out of resource manager
URL: https://github.com/apache/incubator-pinot/pull/4506#discussion_r312296816
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
 ##########
 @@ -426,6 +432,29 @@ private void initPinotCrypterFactory() {
     }
   }
 
+  /**
+   * Register and connect to Helix cluster as PARTICIPANT role.
+   */
+  private HelixManager registerAndConnectAsHelixParticipant() {
+    String controllerParticipantInstanceId = _helixResourceManager.getInstanceId();
 
 Review comment:
   Don't fetch instanceId from resource manager, explicitly create one instanceId for controller, one for participant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org