You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/17 02:58:07 UTC

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2700: nRF52 various minor fixes

v01d commented on a change in pull request #2700:
URL: https://github.com/apache/incubator-nuttx/pull/2700#discussion_r559069376



##########
File path: arch/arm/src/nrf52/nrf52_gpio.c
##########
@@ -192,6 +202,59 @@ static inline void nrf52_gpio_sense(nrf52_pinset_t cfgset,
   putreg32(regval, offset);
 }
 
+/****************************************************************************
+ * Name: nrf52_gpio_drive
+ *
+ * Description:
+ *   Set DRIVE configuration for a pin
+ *
+ ****************************************************************************/
+
+static inline void nrf52_gpio_drive(nrf52_pinset_t cfgset,

Review comment:
       since this would then require changing various other parts of this code do you mind if I do it in a separate PR?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org