You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/01 11:09:13 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #3472: chore: fix 'make deps'

spacewander commented on a change in pull request #3472:
URL: https://github.com/apache/apisix/pull/3472#discussion_r567740838



##########
File path: Makefile
##########
@@ -55,7 +55,9 @@ help: default
 .PHONY: deps
 deps: default
 ifeq ($(LUAROCKS_VER),luarocks 3.)
+ifeq ("$(wildcard ~/.luarocks)", "")

Review comment:
       @Yiyiyimu 
   I think you are making something wrong. The `make deps` only install dependencies locally. There is no need to call `sudo`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org