You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/03/05 15:55:30 UTC
[GitHub] [hadoop] sebastian-nagel opened a new pull request #1878:
HADOOP-16909 Typo in distcp counters
sebastian-nagel opened a new pull request #1878: HADOOP-16909 Typo in distcp counters
URL: https://github.com/apache/hadoop/pull/1878
- also fixes same type in unit tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1878: HADOOP-16909 Typo
in distcp counters
Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1878: HADOOP-16909 Typo in distcp counters
URL: https://github.com/apache/hadoop/pull/1878#issuecomment-595776874
let me do a local test run of the distcp tests; also curious about the yarn failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #1878:
HADOOP-16909 Typo in distcp counters
Posted by GitBox <gi...@apache.org>.
steveloughran commented on a change in pull request #1878: HADOOP-16909 Typo in distcp counters
URL: https://github.com/apache/hadoop/pull/1878#discussion_r388462964
##########
File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFile.java
##########
@@ -109,15 +109,15 @@ private int readAndCheckbytes(Scanner scanner, int start, int n)
byte[] val = readValue(scanner);
String keyStr = String.format(localFormatter, i);
String valStr = value + keyStr;
- assertTrue("btyes for keys do not match " + keyStr + " "
+ assertTrue("bytes for keys do not match " + keyStr + " "
Review comment:
pull this into a const and it could be referred everywhere.
Also, this is the time to move to assertEquals, if it does array comparisons. If not, then never mind
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] sebastian-nagel commented on issue #1878: HADOOP-16909
Typo in distcp counters
Posted by GitBox <gi...@apache.org>.
sebastian-nagel commented on issue #1878: HADOOP-16909 Typo in distcp counters
URL: https://github.com/apache/hadoop/pull/1878#issuecomment-595436465
Reason of the failed distcp unit tests: "java.lang.OutOfMemoryError: unable to create new native thread"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran merged pull request #1878: HADOOP-16909 Typo
in distcp counters
Posted by GitBox <gi...@apache.org>.
steveloughran merged pull request #1878: HADOOP-16909 Typo in distcp counters
URL: https://github.com/apache/hadoop/pull/1878
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1878: HADOOP-16909 Typo
in distcp counters
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1878: HADOOP-16909 Typo in distcp counters
URL: https://github.com/apache/hadoop/pull/1878#issuecomment-595376019
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 1m 9s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 18m 56s | trunk passed |
| +1 :green_heart: | compile | 17m 48s | trunk passed |
| +1 :green_heart: | checkstyle | 2m 30s | trunk passed |
| +1 :green_heart: | mvnsite | 2m 7s | trunk passed |
| +1 :green_heart: | shadedclient | 19m 31s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 33s | trunk passed |
| +0 :ok: | spotbugs | 0m 51s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 2m 56s | trunk passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 17s | the patch passed |
| +1 :green_heart: | compile | 16m 45s | the patch passed |
| +1 :green_heart: | javac | 16m 45s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 30s | the patch passed |
| +1 :green_heart: | mvnsite | 2m 7s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 16m 58s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 2m 18s | the patch passed |
| +1 :green_heart: | findbugs | 4m 58s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 1m 11s | hadoop-common in the patch failed. |
| -1 :x: | unit | 29m 38s | hadoop-distcp in the patch passed. |
| +0 :ok: | asflicense | 1m 7s | ASF License check generated no output? |
| | | 147m 8s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.tools.TestDistCpSyncReverseFromTarget |
| | hadoop.tools.TestFileBasedCopyListing |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1878/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1878 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 3931c65e0a07 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 004e955 |
| Default Java | 1.8.0_242 |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1878/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1878/1/artifact/out/patch-unit-hadoop-tools_hadoop-distcp.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1878/1/testReport/ |
| Max. process+thread count | 431 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-distcp U: . |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1878/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1878: HADOOP-16909 Typo
in distcp counters
Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1878: HADOOP-16909 Typo in distcp counters
URL: https://github.com/apache/hadoop/pull/1878#issuecomment-595364018
BTW, @sebastian-nagel -you know the last person who touches distcp code has to maintain it until someone else provides a PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1878: HADOOP-16909 Typo
in distcp counters
Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1878: HADOOP-16909 Typo in distcp counters
URL: https://github.com/apache/hadoop/pull/1878#issuecomment-595362777
This has long annoyed me. But I've always worried about what would break. Maybe it is time to find out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1878: HADOOP-16909 Typo
in distcp counters
Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1878: HADOOP-16909 Typo in distcp counters
URL: https://github.com/apache/hadoop/pull/1878#issuecomment-596571241
+1...did a test run and all seemed fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org