[GitHub] [pulsar] codelipenghui commented on a change in pull request #10963: [Broker] Fix create partitioned topic in replicated namespace

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #10963:
URL: https://github.com/apache/pulsar/pull/10963#discussion_r654318386



##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -361,6 +361,42 @@
      */
     CompletableFuture<Void> createPartitionedTopicAsync(String topic, int numPartitions);
 
+    /**
+     * Create a partitioned topic.
+     * <p/>
+     * Create a partitioned topic. It needs to be called before creating a producer for a partitioned topic.
+     * <p/>
+     *
+     * @param topic
+     *            Topic name
+     * @param numPartitions
+     *            Number of partitions to create of the topic
+     * @param createLocalTopicOnly
+     *            False indicate create topic in all replicate clusters,
+     *            true indicate only create topic in local cluster.
+     * @throws PulsarAdminException
+     */
+    void createPartitionedTopic(

Review comment:
       Yes, we don't need to expose to users, keep it in the implementation is a better solution




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org