You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/03 10:44:24 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #15013: Enable Connection creation from Vault parameters

mik-laj commented on a change in pull request #15013:
URL: https://github.com/apache/airflow/pull/15013#discussion_r606649464



##########
File path: airflow/providers/hashicorp/secrets/vault.py
##########
@@ -18,8 +18,10 @@
 """Objects relating to sourcing connections & variables from Hashicorp Vault"""
 from typing import Optional
 
+from airflow.models.connection import Connection
 from airflow.providers.hashicorp._internal_client.vault_client import _VaultClient  # noqa
 from airflow.secrets import BaseSecretsBackend
+from airflow.secrets.local_filesystem import _create_connection

Review comment:
       We should extract the common part to the new package. This is problematic now, so I started discussions on the mailing list. See: https://lists.apache.org/thread.html/r713f180120d0a39b53567812eb5db34f992ec81979818d2175598b71%40%3Cdev.airflow.apache.org%3E




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org