You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by "Ivanov, Alexey A" <al...@intel.com> on 2006/10/17 12:47:11 UTC
[classlib][swing] test "hangs": j.s.filechooser.FileSystemViewTest prompts to insert disk into drive A:
Hello everyone,
When running tests on Windows,
FileSystemViewTest.testGetSystemDisplayName() pops up a dialog prompting
to insert disk into drive A:. This dialog prevents normal running of
other tests.
IMO, the problem assertion could be deleted without loss of coverage.
Any other comments/opinions?
See the JIRA issue: https://issues.apache.org/jira/browse/HARMONY-1892
Regards,
Alexey.
P.S. The problem code is at lines 85-86 in FileSystemViewTest.java:
file = File.listRoots()[0];
assertNotSame(file.getName(), view.getSystemDisplayName(file));
--
Alexey A. Ivanov
Intel Middleware Product Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib][swing] test "hangs": j.s.filechooser.FileSystemViewTest prompts to insert disk into drive A:
Posted by Richard Liang <ri...@gmail.com>.
On 10/17/06, Ivanov, Alexey A <al...@intel.com> wrote:
> Hello everyone,
>
> When running tests on Windows,
> FileSystemViewTest.testGetSystemDisplayName() pops up a dialog prompting
> to insert disk into drive A:. This dialog prevents normal running of
> other tests.
Is this still a problem? I cannot reproduce it on my WinXP. Do I miss anything?
Richard
>
> IMO, the problem assertion could be deleted without loss of coverage.
> Any other comments/opinions?
>
> See the JIRA issue: https://issues.apache.org/jira/browse/HARMONY-1892
>
>
> Regards,
> Alexey.
>
>
> P.S. The problem code is at lines 85-86 in FileSystemViewTest.java:
> file = File.listRoots()[0];
> assertNotSame(file.getName(), view.getSystemDisplayName(file));
>
>
> --
> Alexey A. Ivanov
> Intel Middleware Product Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Richard Liang
China Development Lab, IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib][swing] test "hangs": j.s.filechooser.FileSystemViewTest prompts to insert disk into drive A:
Posted by Alexey Varlamov <al...@gmail.com>.
2006/10/17, Ivanov, Alexey A <al...@intel.com>:
> Hello everyone,
>
> When running tests on Windows,
> FileSystemViewTest.testGetSystemDisplayName() pops up a dialog prompting
> to insert disk into drive A:. This dialog prevents normal running of
> other tests.
>
LOL
> IMO, the problem assertion could be deleted without loss of coverage.
> Any other comments/opinions?
>
> See the JIRA issue: https://issues.apache.org/jira/browse/HARMONY-1892
>
>
> Regards,
> Alexey.
>
>
> P.S. The problem code is at lines 85-86 in FileSystemViewTest.java:
> file = File.listRoots()[0];
> assertNotSame(file.getName(), view.getSystemDisplayName(file));
The assertion doesn't look foolproof anyway. Accordingly to spec
getSystemDisplayName() should return *some* name, max what we may
assert that it is not null and not empty.
>
> --
> Alexey A. Ivanov
> Intel Middleware Product Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org