[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11240: refactor: Replace usages of reactable in TableLoader

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #11240:
URL: https://github.com/apache/incubator-superset/pull/11240#discussion_r506218433



##########
File path: superset-frontend/src/components/TableLoader.jsx
##########
@@ -18,12 +18,13 @@
  */
 import React from 'react';
 import PropTypes from 'prop-types';
-import { Table, Tr, Td } from 'reactable-arc';
+import memoize from 'lodash/memoize';

Review comment:
       I totally agree. I converted it to functional component and typescript. Would you mind if I added a storybook and tests in a separate PR?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org