[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9651: Add example and notice about task type Stored Procedure

[GitBox <gi...@apache.org>]

zhongjiajie commented on code in PR #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651#discussion_r873297575


##########
docs/docs/zh/guide/task/stored-procedure.md:
##########
@@ -1,12 +1,47 @@
 # 存储过程节点
 
+## 综述
+
+`PROCEDURE` 任务类型，用于执行存储过程的程序
+
+## 创建任务
+
 - 根据选择的数据源，执行存储过程。
 > 拖动工具栏中的![PNG](https://analysys.github.io/easyscheduler_docs_cn/images/toolbar_PROCEDURE.png)任务节点到画板中，如下图所示：

Review Comment:
   Please change this png link from `analysys.github.io` to our local file like you add then in its `Task Example` section



##########
docs/docs/en/guide/task/stored-procedure.md:
##########
@@ -1,4 +1,10 @@
-# Stored Procedure
+# PROCEDURE
+
+## Overview
+
+`PROCEDURE` task type, the program used to execute the stored procedure
+
+## Create Task
 
 - Execute the stored procedure according to the selected DataSource.

Review Comment:
   We should also add how to create task like others `- Drag from the toolbar <img src="/img/tasks/icons/procedure.png" width="25"/> to the canvas.`



##########
docs/configs/docsdev.js:
##########
@@ -470,7 +470,7 @@ export default {
                                 link: '/zh-cn/docs/dev/user_doc/guide/task/dependent.html',
                             },
                             {
-                                title: 'Stored Procedure',
+                                title: 'Procedure,
                                 link: '/zh-cn/docs/dev/user_doc/guide/task/stored-procedure.html',

Review Comment:
   I suggest we should change the task file name from `stored-procedure` to `procedure` to keep the file name same as the content title of first line
   ```suggestion
                                   link: '/zh-cn/docs/dev/user_doc/guide/task/procedure.html',
   ```



##########
docs/configs/docsdev.js:
##########
@@ -470,7 +470,7 @@ export default {
                                 link: '/zh-cn/docs/dev/user_doc/guide/task/dependent.html',
                             },
                             {
-                                title: 'Stored Procedure',
+                                title: 'Procedure,
                                 link: '/zh-cn/docs/dev/user_doc/guide/task/stored-procedure.html',

Review Comment:
   Please also change the EN document



##########
docs/docs/en/guide/task/stored-procedure.md:
##########
@@ -1,4 +1,10 @@
-# Stored Procedure
+# PROCEDURE

Review Comment:
   ```suggestion
   # Procedure
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org