You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/29 16:58:09 UTC

[GitHub] [beam] aromanenko-dev commented on a change in pull request #15832: [BEAM-13149] Changing readWithPartitions to work with longs. Removing untested (non-working) code path

aromanenko-dev commented on a change in pull request #15832:
URL: https://github.com/apache/beam/pull/15832#discussion_r739398878



##########
File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -1060,53 +1060,36 @@ public void populateDisplayData(DisplayData.Builder builder) {
           getUpperBound() - getLowerBound() >= getNumPartitions(),
           "The specified number of partitions is more than the difference between upper bound and lower bound");
 
-      if (getUpperBound() == MAX_VALUE || getLowerBound() == 0) {

Review comment:
       What's about this check then? E.g. if upperBound or lowerBound wasn't specified?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org