You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/01 22:51:07 UTC
[GitHub] [tvm] tkonolige opened a new pull request, #11530: [PROFILER] Add configuration information to profiler
tkonolige opened a new pull request, #11530:
URL: https://github.com/apache/tvm/pull/11530
Configuration is a place to store extra information related to the specific profiler run. Right now it is just the executor used and the number of threads. The roofline analysis also adds peak flops and peak bandwidth.
In the future I'd like to add information about the target, but it would have to be piped through the compiled library.
@AndrewZhaoLuo @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo merged pull request #11530: [PROFILER] Add configuration information to profiler
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo merged PR #11530:
URL: https://github.com/apache/tvm/pull/11530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on a diff in pull request #11530: [PROFILER] Add configuration information to profiler
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on code in PR #11530:
URL: https://github.com/apache/tvm/pull/11530#discussion_r890290381
##########
src/runtime/profiling.cc:
##########
@@ -592,14 +617,20 @@ String ReportNode::AsTable(bool sort, bool aggregate, bool compute_col_sums) con
}
s << std::endl;
}
+
+ // Add configuration information. It will not be aligned with the columns.
+ s << std::endl << "Configuration" << std::endl << "-------------" << std::endl;
+ for (auto kv : configuration) {
+ s << kv.first << ": " << print_metric(kv.second) << std::endl;
+ }
return s.str();
}
std::string DeviceString(Device dev) {
return DeviceName(dev.device_type) + std::to_string(dev.device_id);
}
-Report Profiler::Report(bool aggregate, bool sort) {
+Report Profiler::Report() {
Review Comment:
Interesting these variables were never used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #11530: [PROFILER] Add configuration information to profiler
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on PR #11530:
URL: https://github.com/apache/tvm/pull/11530#issuecomment-1147581591
Will review today and hopefully merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org