You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@celeborn.apache.org by "boneanxs (via GitHub)" <gi...@apache.org> on 2023/06/28 10:45:21 UTC

[GitHub] [incubator-celeborn] boneanxs commented on a diff in pull request #1637: [CELEBORN-725][MINOR] Refine congestion code

boneanxs commented on code in PR #1637:
URL: https://github.com/apache/incubator-celeborn/pull/1637#discussion_r1245034022


##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/congestcontrol/CongestionController.java:
##########


Review Comment:
   Currently, from my perspective, the main time-consuming step is to `trimMemoryUsage` to get real memoryUsage,
   +1 for that we can move the logic of determining whether the worker is highWatermark to a separate thread, in which case all connections could share this value. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org