You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "chia7712 (via GitHub)" <gi...@apache.org> on 2025/11/02 15:40:58 UTC

Re: [PR] KAFKA-19734 Adding application tag to clientstate metric [kafka]

chia7712 commented on code in PR #20766:
URL: https://github.com/apache/kafka/pull/20766#discussion_r2484872956


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java:
##########
@@ -284,6 +288,7 @@ public Map<String, String> clientLevelTagMap() {
         final Map<String, String> tagMap = new LinkedHashMap<>();
         tagMap.put(CLIENT_ID_TAG, clientId);
         tagMap.put(PROCESS_ID_TAG, processId);
+        tagMap.put(APPLICATION_ID_TAG, applicationId);

Review Comment:
   Pardon me. I see this new tag applied al all metrics, yet the KIP only specifies the `client-state` metric. Am I misunderstanding the scope? thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org