You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by WeichenXu123 <gi...@git.apache.org> on 2016/07/12 15:20:12 UTC
[GitHub] spark pull request #14157: [SPARK-16500][ML][MLLib][Optimizer] add LBFGS con...
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/14157
[SPARK-16500][ML][MLLib][Optimizer] add LBFGS convergence warning for all used place in MLLib
## What changes were proposed in this pull request?
Add warning_for the following case when LBFGS training not actually convergence:
1) LogisticRegression
2) AFTSurvivalRegression
3) LBFGS algorithm wrapper in mllib package
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WeichenXu123/spark add_lbfgs_convergence_warning_for_all_used_place
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14157
----
commit 022ffc1d1b2f836eee2b0dedeb1e62df5d84e6ab
Author: WeichenXu <we...@outlook.com>
Date: 2016-07-11T13:24:22Z
add_lbfgs_convergence_warning_for_all_used_place
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14157: [SPARK-16500][ML][MLLib][Optimizer] add LBFGS convergenc...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14157
**[Test build #62173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62173/consoleFull)** for PR 14157 at commit [`022ffc1`](https://github.com/apache/spark/commit/022ffc1d1b2f836eee2b0dedeb1e62df5d84e6ab).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14157: [SPARK-16500][ML][MLLib][Optimizer] add LBFGS con...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14157: [SPARK-16500][ML][MLLib][Optimizer] add LBFGS convergenc...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14157
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62173/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14157: [SPARK-16500][ML][MLLib][Optimizer] add LBFGS convergenc...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14157
**[Test build #62173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62173/consoleFull)** for PR 14157 at commit [`022ffc1`](https://github.com/apache/spark/commit/022ffc1d1b2f836eee2b0dedeb1e62df5d84e6ab).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14157: [SPARK-16500][ML][MLLib][Optimizer] add LBFGS convergenc...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14157
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org