You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2016/11/21 23:02:11 UTC

Review Request 53968: ATLAS-1314: update typedefs with addition of 'options' attribute

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53968/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-1314
    https://issues.apache.org/jira/browse/ATLAS-1314


Repository: atlas


Description
-------

- added 'options' attribute to AtlasBaseTypeDef
- created 'UPDATE_TYPEDEF_OPTIONS' patch handler
- added typedef-patch to update options for hive_table and hive_column


Diffs
-----

  addons/models/patches/002-hive_column_table_add_options.json PRE-CREATION 
  common/src/main/java/org/apache/atlas/repository/Constants.java 6175ac2 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 8ee3458 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java d953633 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 2e34127 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 86e2388 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java e4c5e1b 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 582b095 
  repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java c8c22eb 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java ffa73e2 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 53d6591 

Diff: https://reviews.apache.org/r/53968/diff/


Testing
-------

- verified that Atlas server startup loads the typedef-patches that add options attribute and REST APIs handle the new attribute correctly


Thanks,

Madhan Neethiraj

Re: Review Request 53968: ATLAS-1314: update typedefs with addition of 'options' attribute

Posted by Sarath Subramanian <sa...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53968/#review156548
-----------------------------------------------------------



Could you add unit tests for this change.

- Sarath Subramanian


On Nov. 21, 2016, 3:02 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53968/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 3:02 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1314
>     https://issues.apache.org/jira/browse/ATLAS-1314
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - added 'options' attribute to AtlasBaseTypeDef
> - created 'UPDATE_TYPEDEF_OPTIONS' patch handler
> - added typedef-patch to update options for hive_table and hive_column
> 
> 
> Diffs
> -----
> 
>   addons/models/patches/002-hive_column_table_add_options.json PRE-CREATION 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 6175ac2 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 8ee3458 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java d953633 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 2e34127 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 86e2388 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java e4c5e1b 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 582b095 
>   repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java c8c22eb 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java ffa73e2 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 53d6591 
> 
> Diff: https://reviews.apache.org/r/53968/diff/
> 
> 
> Testing
> -------
> 
> - verified that Atlas server startup loads the typedef-patches that add options attribute and REST APIs handle the new attribute correctly
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 53968: ATLAS-1314: update typedefs with addition of 'options' attribute

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53968/#review156546
-----------------------------------------------------------


Ship it!




Ship It!

- Apoorv Naik


On Nov. 21, 2016, 11:02 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53968/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 11:02 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1314
>     https://issues.apache.org/jira/browse/ATLAS-1314
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - added 'options' attribute to AtlasBaseTypeDef
> - created 'UPDATE_TYPEDEF_OPTIONS' patch handler
> - added typedef-patch to update options for hive_table and hive_column
> 
> 
> Diffs
> -----
> 
>   addons/models/patches/002-hive_column_table_add_options.json PRE-CREATION 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 6175ac2 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 8ee3458 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java d953633 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 2e34127 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 86e2388 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java e4c5e1b 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 582b095 
>   repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java c8c22eb 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java ffa73e2 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 53d6591 
> 
> Diff: https://reviews.apache.org/r/53968/diff/
> 
> 
> Testing
> -------
> 
> - verified that Atlas server startup loads the typedef-patches that add options attribute and REST APIs handle the new attribute correctly
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>