You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by anthonycorbacho <gi...@git.apache.org> on 2016/08/17 07:03:34 UTC
[GitHub] zeppelin pull request #1338: [WIP ] Zeppelin 1307 - Implement notebook revis...
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1338
[WIP ] Zeppelin 1307 - Implement notebook revision in Zeppelinhub repo
### What is this PR for?
Implement versioning in ZeppelinHub notebook storage.
### What type of PR is it?
Improvement
### Todos
* [ ] - Implement Versioning API
### What is the Jira issue?
* [ZEPPELIN-1307](https://issues.apache.org/jira/browse/ZEPPELIN-1307)
### How should this be tested?
Edit `zeppelin-env.sh` and add `org.apache.zeppelin.notebook.repo.zeppelinhub.ZeppelinHubRepo` in `ZEPPELIN_NOTEBOOK_STORAGE`.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anthonycorbacho/incubator-zeppelin ZEPPELIN-1307
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1338.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1338
----
commit 9bd0946233f8b8ffd0a66effe46bb66303cc676b
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-08-17T03:54:07Z
Close InputStream in asyncGet
commit 3942a781b55c780de5aa11038f62d6494b620bdd
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-08-17T03:58:44Z
Implement get revision
commit 5d4b54b3901a23eb396bded45a2f95565afa7610
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-08-17T05:45:52Z
Implement checkpoint method
commit 2395a6ea2a70f39fa95b7b26bc461518e3653326
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-08-17T06:56:54Z
Light refactor of ZeppelinHubRestapiHandler and extract api call to a single method
commit 74a0cdbb92908b7b7c9bc104e2541d32a22dacbe
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-08-17T06:59:17Z
change asyncPutWithResponseBody to accpet url instead of noteId
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1338
@bzz Regarding your comment, I couldnt agree more, i am not a big fan of returning `null`. I created an issue in [JIRA - 1352](https://issues.apache.org/jira/browse/ZEPPELIN-1352) and I will address it ASAP after merging this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1338: [WIP ] Zeppelin 1307 - Implement notebook revis...
Posted by anthonycorbacho <gi...@git.apache.org>.
GitHub user anthonycorbacho reopened a pull request:
https://github.com/apache/zeppelin/pull/1338
[WIP ] Zeppelin 1307 - Implement notebook revision in Zeppelinhub repo
### What is this PR for?
Implement versioning in ZeppelinHub notebook storage.
### What type of PR is it?
Improvement
### Todos
* [ ] - Implement Versioning API
### What is the Jira issue?
* [ZEPPELIN-1307](https://issues.apache.org/jira/browse/ZEPPELIN-1307)
### How should this be tested?
Edit `zeppelin-env.sh` and add `org.apache.zeppelin.notebook.repo.zeppelinhub.ZeppelinHubRepo` in `ZEPPELIN_NOTEBOOK_STORAGE`.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anthonycorbacho/incubator-zeppelin ZEPPELIN-1307
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1338.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1338
----
commit 9bd0946233f8b8ffd0a66effe46bb66303cc676b
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-08-17T03:54:07Z
Close InputStream in asyncGet
commit 3942a781b55c780de5aa11038f62d6494b620bdd
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-08-17T03:58:44Z
Implement get revision
commit 5d4b54b3901a23eb396bded45a2f95565afa7610
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-08-17T05:45:52Z
Implement checkpoint method
commit 2395a6ea2a70f39fa95b7b26bc461518e3653326
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-08-17T06:56:54Z
Light refactor of ZeppelinHubRestapiHandler and extract api call to a single method
commit 74a0cdbb92908b7b7c9bc104e2541d32a22dacbe
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-08-17T06:59:17Z
change asyncPutWithResponseBody to accpet url instead of noteId
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1338
somehow i keep getting this error when doing checkpoint:
```
ERROR [2016-08-22 14:33:04,618] ({qtp787867107-76} NotebookServer.java[onMessage]:257) - Can't handle message
java.lang.NullPointerException
at org.eclipse.jetty.client.HttpClient.send(HttpClient.java:521)
at org.eclipse.jetty.client.HttpRequest.send(HttpRequest.java:694)
at org.eclipse.jetty.client.HttpRequest.send(HttpRequest.java:678)
at org.apache.zeppelin.notebook.repo.zeppelinhub.rest.ZeppelinhubRestApiHandler.sendToZeppelinHub(ZeppelinhubRestApiHandler.java:157)
at org.apache.zeppelin.notebook.repo.zeppelinhub.rest.ZeppelinhubRestApiHandler.asyncPutWithResponseBody(ZeppelinhubRestApiHandler.java:125)
at org.apache.zeppelin.notebook.repo.zeppelinhub.ZeppelinHubRepo.checkpoint(ZeppelinHubRepo.java:201)
at org.apache.zeppelin.notebook.repo.NotebookRepoSync.checkpoint(NotebookRepoSync.java:334)
at org.apache.zeppelin.notebook.Notebook.checkpointNote(Notebook.java:358)
at org.apache.zeppelin.socket.NotebookServer.checkpointNotebook(NotebookServer.java:1182)
at org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:233)
at org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:56)
at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128)
at org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69)
at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65)
at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122)
at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161)
at org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309)
at org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214)
at org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220)
at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258)
at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632)
at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480)
at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
at java.lang.Thread.run(Thread.java:745)
```
not sure what's the problem though, let me know if doing something wrong
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1338
**L**ets **G**et **T**o **M**erge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1338: Zeppelin 1307 - Implement notebook revision in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1338
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1338
merging if no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1338: [WIP ] Zeppelin 1307 - Implement notebook revis...
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho closed the pull request at:
https://github.com/apache/zeppelin/pull/1338
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1338
@khalidhuseynov fixed the issue, thank for testing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1338
ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1338
tested and works well now! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---