You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/05/08 19:58:34 UTC

[GitHub] [groovy] eric-milles opened a new pull request #1241: GROOVY-9545: add extension method for stream to array using class literal

eric-milles opened a new pull request #1241:
URL: https://github.com/apache/groovy/pull/1241


   https://issues.apache.org/jira/browse/GROOVY-9545
   
   Looking into STC.  And waiting on comment/feedback in JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [groovy] paulk-asert commented on pull request #1241: GROOVY-9545: add extension method for stream to array using class literal

Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1241:
URL: https://github.com/apache/groovy/pull/1241#issuecomment-629755673


   I merged and made a few tweaks. I ended up leaving it in PluginDefaultGroovyMethods since all the other stream DGM methods were in there. Also, my suggestion for null checking doesn't offer much since it selects the built-in variant in that case anyway. We might add a NullObject variant at some future point when we add proper support for that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [groovy] paulk-asert commented on pull request #1241: GROOVY-9545: add extension method for stream to array using class literal

Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1241:
URL: https://github.com/apache/groovy/pull/1241#issuecomment-629619897


   +1 with the following comments:
   - I'd suggest `@since` of 3.0.4 if merged soon
   - we can probably do a better error message for the case where `type` is null
   -  no need to have in `PluginDefaultGroovyMethods` just `DefaultGroovyMethods` since we know we have JDK8+ for 3+
   - perhaps a couple of additional tests for arrays of arrays, e.g.:
   ```
   assert Arrays.equals([].stream().toArray(String[]), new String[0][])
   assert Arrays.deepEquals([['x'] as String[]].stream().toArray(String[]), [['x'] as String[]] as String[][])
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [groovy] asfgit closed pull request #1241: GROOVY-9545: add extension method for stream to array using class literal

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1241:
URL: https://github.com/apache/groovy/pull/1241


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org