You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/08/26 15:51:45 UTC

[GitHub] [nifi] MikeThomsen commented on a change in pull request #5332: NIFI-9080 Converted nifi-commons to use JUnit 5.

MikeThomsen commented on a change in pull request #5332:
URL: https://github.com/apache/nifi/pull/5332#discussion_r696763080



##########
File path: nifi-commons/nifi-security-utils/src/test/groovy/org/apache/nifi/security/util/crypto/NiFiLegacyCipherProviderGroovyTest.groovy
##########
@@ -260,9 +247,14 @@ class NiFiLegacyCipherProviderGroovyTest {
      * from the password using a long digest result at the time of key length checking.
      * @throws IOException
      */
-    @Ignore("Only needed once to determine max supported password lengths")
+    @Disabled("Only needed once to determine max supported password lengths")
+    @Ignore

Review comment:
       I understand the logic, and will see what I can reasonably do there. That said, for the sake of keeping the build stable I am going to err strongly on the side of caution and keep tests disabled unless I or someone else feels confident that they should be enabled. A lot of these tests are old and odds are good that for a big chunk of them we may not have much memory of why they were disabled.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org