[jira] [Resolved] (AVRO-1560) SNAPPY_INCLUDE_DIR not accounted in CMakeLists.txt

["Martin Kleppmann (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AVRO-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Kleppmann resolved AVRO-1560.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.8.0

+1. I needed this too in order to make the build work with Homebrew on Mac OS X.

I've committed this to branch-1.8 and trunk. Thanks for your contribution, [~ujjwal.wadhawan]!

> SNAPPY_INCLUDE_DIR not accounted in CMakeLists.txt
> --------------------------------------------------
>
>                 Key: AVRO-1560
>                 URL: https://issues.apache.org/jira/browse/AVRO-1560
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.7.7
>            Reporter: Ujjwal
>            Priority: Minor
>              Labels: build
>             Fix For: 1.8.0
>
>         Attachments: AVRO-1560.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The current CMakeLists.txt does not account for Snappy include folders causing the compilation to fail when a custom snappy location is provided using -DSNAPPY_ROOT_DIR
> e.g .
> {code:xml}
> cmake avro-c-1.7.7 -DSNAPPY_ROOT_DIR=${SNAPPY_INSTALL_DIR}
> {code}
> In https://github.com/apache/avro/blob/release-1.7.7/lang/c/CMakeLists.txt#L143 we should include 
> {code:xml}
> include_directories(${SNAPPY_INCLUDE_DIR})
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)