You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2011/11/20 14:42:53 UTC
svn commit: r1204169 -
/jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java
Author: pmouawad
Date: Sun Nov 20 13:42:53 2011
New Revision: 1204169
URL: http://svn.apache.org/viewvc?rev=1204169&view=rev
Log:
Removed wrong old javadocs, Now functions are notified when a test has ended.
Modified:
jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java
Modified: jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java?rev=1204169&r1=1204168&r2=1204169&view=diff
==============================================================================
--- jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java (original)
+++ jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java Sun Nov 20 13:42:53 2011
@@ -112,10 +112,8 @@ public class StringFromFile extends Abst
myName = "StringFromFile_";//$NON-NLS-1$
}
- /*
- * Warning: the file will generally be left open at the end of a test run.
- * This is because functions don't (yet) have any way to find out when a
- * test has ended ...
+ /**
+ * Close file and log
*/
private void closeFile() {
if (myBread == null) {
@@ -126,7 +124,7 @@ public class StringFromFile extends Abst
try {
myBread.close();
} catch (IOException e) {
- log.error("closeFile() error: " + e.toString());//$NON-NLS-1$
+ log.error("closeFile() error: " + e.toString(), e);//$NON-NLS-1$
}
}