You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2016/02/11 10:08:40 UTC

Review Request 43476: Make amazon2015 to be part of redhat6 family

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43476/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-15007
    https://issues.apache.org/jira/browse/AMBARI-15007


Repository: ambari


Description
-------

We have discussed the solution for this with Sumit Mohanty.  
We decided to avoid introducing new os family for amazon.  
And to simply add aliases section to os_family.json like this:

    
    
      "aliases": {
        "amazon2015": "amazon6"
      }
    

The only disadvantage is that when choosing repo-url, user might be confused
that centos6 url is for amazon 2015.  
But that what initially what I was asked to do.

Also this jira should include using /etc/system-release instead of /etc/issue
to detect amazon os. (/etc/os-release seems to be absent on some centos
distros, so I think it's not reliable)


Diffs
-----

  ambari-common/src/main/python/ambari_commons/os_check.py c5457bb 
  ambari-common/src/main/python/ambari_commons/resources/os_family.json 13014fc 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/JsonOsFamilyRoot.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java 37a6db3 
  ambari-server/src/main/resources/stacks/HDP/2.2/repos/repoinfo.xml 9decf51 
  ambari-server/src/main/resources/stacks/HDP/2.3/repos/repoinfo.xml 279134b 
  ambari-server/src/main/resources/stacks/HDP/2.4/repos/repoinfo.xml 6ac43f9 
  ambari-server/src/test/python/TestOSCheck.py cf114a1 

Diff: https://reviews.apache.org/r/43476/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk