You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Blake Bender (Jira)" <ji...@apache.org> on 2021/04/28 21:51:00 UTC
[jira] [Created] (GEODE-9207) Eliminate use of static pointers for
messages PING, CLOSE_CONNECTION, and "all endpoints disconnected" message
Blake Bender created GEODE-9207:
-----------------------------------
Summary: Eliminate use of static pointers for messages PING, CLOSE_CONNECTION, and "all endpoints disconnected" message
Key: GEODE-9207
URL: https://issues.apache.org/jira/browse/GEODE-9207
Project: Geode
Issue Type: Bug
Components: native client
Reporter: Blake Bender
The binary format of these messages apparently doesn't change, and at some point someone thought it would be a great idea to just create each one time rather than call `new` or declare a variable on the stack. This actually leads to several instances of special-case code where we `delete` a pointer _unless_ it's one of these special ones, etc. Additionally, each of them is reported as leaked at shutdown by standard tracking tools. Stop treating these as special, this particular micro-optimization is not worth doing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)