You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kk...@apache.org on 2009/08/13 08:45:11 UTC
svn commit: r803794 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko
Date: Thu Aug 13 06:45:11 2009
New Revision: 803794
URL: http://svn.apache.org/viewvc?rev=803794&view=rev
Log:
veto, vote and proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=803794&r1=803793&r2=803794&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Aug 13 06:45:11 2009
@@ -46,6 +46,17 @@
-0: fhanik - the bug talks about WEB-INF/lib and reload, that would be when reload="true" which should be considered development only
So to make this bug actually worth while fixing, and not impact performance, then it should only do this check on files that
are relevant to the reload of an application, in other words a watched resource
+ -1: kkolinko: (
+ FileDirContext#file() contains a check that file.canRead() is true.
+ A side-effect of this patch will be that files that are not readable
+ will be excluded from the enumeration provided by FileDirContext#list()
+ or FileDirContext#listBindings().
+ I think that it is wrong. If file is not readable it should result in error 404
+ or something like that.
+
+ Thus, we have to revert this change in trunk.
+ I am proposing an alternative patch for bug 45403 below.
+ )
* Backport cleanup of semantics of thisAccessedTime and
lastAccessedTime for sessions:
@@ -187,8 +198,9 @@
* Improve build.properties comment in ant build files.
Backport from trunk.
http://svn.apache.org/viewvc?rev=797425&view=rev
- +1: rjung
+ +1: rjung, kkolinko
-1:
+ kkolinko: Comments are documentation, and thus RTC.
* Port Active Directory improvements to JNDIREalm from trunk
Patch testing successfully by willing volunteer on the users list
@@ -274,3 +286,14 @@
https://issues.apache.org/bugzilla/attachment.cgi?id=24125
+1: markt
-1:
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45403
+ Add a check when enumerating jar files, and
+ do not suppress IO errors when starting a web application.
+ Note:
+ - I cannot test bug 45403 on Windows, as it is Un*x-specific
+ - tested in normal operation, with unpackWARs = "true" and "false"
+ - this has not yet been applied to trunk
+ http://people.apache.org/~kkolinko/patches/2009-08-13_bug45403-tc6.patch
+ +1: kkolinko
+ -1:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r803794 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Konstantin Kolinko <kn...@gmail.com>.
2009/8/15 Mark Thomas <ma...@apache.org>:
> kkolinko@apache.org wrote:
>> + Note:
>> + - I cannot test bug 45403 on Windows, as it is Un*x-specific
>
> I assume you mean that you haven't been able to test this on *nix. If
> not, ignore most of what I have written below :)
>
> There are a couple of options here.
> As an Apache committer, you can apply for a full MSDN license. This
> should come up again shortly as the current licenses expire in November.
> You could then use MS's virtual server.
>
> I use VMWare Workstation (which you have to pay for) but VMWare server
> is available for free and should do what you need to do to test stuff on
> *nix.
>
Thank you for your suggestions, Mark.
It is useful information, I haven't heard about that MSDN opportunity
before. Let's see if I will need that, I do not right now.
I am using VMWare Player (the free one), and have two different Linux
VMs to run with it. Maybe I shouldn't be lazy to fire up one of them
next time.
Thanks for testing.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r803794 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
kkolinko@apache.org wrote:
> + -1: kkolinko: (
> + FileDirContext#file() contains a check that file.canRead() is true.
> + A side-effect of this patch will be that files that are not readable
> + will be excluded from the enumeration provided by FileDirContext#list()
> + or FileDirContext#listBindings().
> + I think that it is wrong. If file is not readable it should result in error 404
> + or something like that.
I think that point is debatable but...
> +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45403
> + Add a check when enumerating jar files, and
> + do not suppress IO errors when starting a web application.
> + Note:
> + - I cannot test bug 45403 on Windows, as it is Un*x-specific
I assume you mean that you haven't been able to test this on *nix. If
not, ignore most of what I have written below :)
There are a couple of options here.
As an Apache committer, you can apply for a full MSDN license. This
should come up again shortly as the current licenses expire in November.
You could then use MS's virtual server.
I use VMWare Workstation (which you have to pay for) but VMWare server
is available for free and should do what you need to do to test stuff on
*nix.
> + - tested in normal operation, with unpackWARs = "true" and "false"
> + - this has not yet been applied to trunk
It works for me on linux so I will revert my patch in trunk and apply
your alternative.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org