You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/06/08 06:45:29 UTC

[GitHub] [hbase] tomscut commented on a change in pull request #3325: HBASE-25934 Add username for RegionScannerHolder

tomscut commented on a change in pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#discussion_r647156436



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -1430,6 +1431,17 @@ static String getRemoteClientIpAndPort() {
     return Address.fromParts(address.getHostAddress(), rpcCall.getRemotePort()).toString();
   }
 
+  /**
+   * @return Remote client's username.
+   */
+  static String getUserName() {

Review comment:
       > Why not return optional here?
   
   Thanks @Apache9 for your review. Because the final result is turned into a String, in keeping with the style of this method (getRemoteLientiPandPort()). 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org