Re: [PR] KAFKA-20106: Ensure reconciled assignment updated within poll [kafka]

["lianetm (via GitHub)" <gi...@apache.org>]

lianetm commented on PR #21495:
URL: https://github.com/apache/kafka/pull/21495#issuecomment-4067094624

   Hey @lucasbru , this is ready for another pass, comments addressed.
   
   And actually by reviewing your last comment I though of a simplified/consolidated approach reusing what we already had, to go the app thread when a reconciliation completes (onPartitionsAssigned hook). So I'm piggybacking the assignment update on the event triggered for onPartitionsAssigned when a reconciliation completes, but ensuring we always trigger it, go to the app thread, trigger the assignment update from there, run callback if needed.So commit or no commit, callback or no callback, this ensures we trigger and complete the assignment update from the app thread whenever a reconciliation completes (this extra hop and ApplyAssignment from the app thread is only when a new assignment is reconciled, so shouldn't affect normal runs of the consumer when assignment is stable). I updated the PR description too, take a look and lmk. Thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org