You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/05/15 04:56:23 UTC

Review Request: FLUME-2044. HDFS Sink impersonation fails after the first file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11168/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Changed the way runPrivileged() is called, so it is called from the timeout thread.


This addresses bug FLUME-2044.
    https://issues.apache.org/jira/browse/FLUME-2044


Diffs
-----

  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 0897c97 

Diff: https://reviews.apache.org/r/11168/diff/


Testing
-------

Manually verified.


Thanks,

Hari Shreedharan


Re: Review Request: FLUME-2044. HDFS Sink impersonation fails after the first file

Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11168/#review20560
-----------------------------------------------------------

Ship it!


+1, this looks good

- Mike Percy


On May 15, 2013, 4:17 a.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11168/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 4:17 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Changed the way runPrivileged() is called, so it is called from the timeout thread.
> 
> 
> This addresses bug FLUME-2044.
>     https://issues.apache.org/jira/browse/FLUME-2044
> 
> 
> Diffs
> -----
> 
>   flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 0897c97 
> 
> Diff: https://reviews.apache.org/r/11168/diff/
> 
> 
> Testing
> -------
> 
> Manually verified.
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>


Re: Review Request: FLUME-2044. HDFS Sink impersonation fails after the first file

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11168/
-----------------------------------------------------------

(Updated May 15, 2013, 4:17 a.m.)


Review request for Flume.


Changes
-------

Making close method synchronized.


Description
-------

Changed the way runPrivileged() is called, so it is called from the timeout thread.


This addresses bug FLUME-2044.
    https://issues.apache.org/jira/browse/FLUME-2044


Diffs (updated)
-----

  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 0897c97 

Diff: https://reviews.apache.org/r/11168/diff/


Testing
-------

Manually verified.


Thanks,

Hari Shreedharan