[GitHub] [hudi] kazdy commented on a diff in pull request #8047: [HUDI-5848][SPARK] No PreCombineField mode - make COMBINE_BEFORE_UPSERT=false automatically

["kazdy (via GitHub)" <gi...@apache.org>]

kazdy commented on code in PR #8047:
URL: https://github.com/apache/hudi/pull/8047#discussion_r1117978967


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieSparkSqlWriter.scala:
##########
@@ -454,6 +454,38 @@ class TestHoodieSparkSqlWriter {
     assert(df.except(trimmedDf).count() == 0)
   }
 
+  /**
+   * Test case for upsert dataset without precombine field and with
+   * auto adjusted COMBINE_BEFORE_UPSERT set to false.
+   */
+  @Disabled

Review Comment:
   I should probably also add E2E test for SQL update



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org