You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2016/06/29 15:16:13 UTC

Review Request 49380: Allow authentication credentials for examples to be altered without editing code

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49380/
-----------------------------------------------------------

Review request for qpid.


Repository: qpid-jms


Description
-------

Changes examples to use system properties for username and password, and adds a note to the README about that.


Diffs
-----

  qpid-jms-examples/README.txt 8a64c7a 
  qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/HelloWorld.java 90ac0b7 
  qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Receiver.java a16dc11 
  qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Sender.java 93d5de4 

Diff: https://reviews.apache.org/r/49380/diff/


Testing
-------


Thanks,

Gordon Sim


Re: Review Request 49380: Allow authentication credentials for examples to be altered without editing code

Posted by Robbie Gemmell <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49380/#review140002
-----------------------------------------------------------


Ship it!




Ship It!

- Robbie Gemmell


On June 29, 2016, 3:16 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49380/
> -----------------------------------------------------------
> 
> (Updated June 29, 2016, 3:16 p.m.)
> 
> 
> Review request for qpid.
> 
> 
> Repository: qpid-jms
> 
> 
> Description
> -------
> 
> Changes examples to use system properties for username and password, and adds a note to the README about that.
> 
> 
> Diffs
> -----
> 
>   qpid-jms-examples/README.txt 8a64c7a 
>   qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/HelloWorld.java 90ac0b7 
>   qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Receiver.java a16dc11 
>   qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Sender.java 93d5de4 
> 
> Diff: https://reviews.apache.org/r/49380/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>