You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/29 08:37:03 UTC

[GitHub] [flink] gaborgsomogyi commented on pull request #19606: [FLINK-27441] fix "nzScroll" calculations

gaborgsomogyi commented on PR #19606:
URL: https://github.com/apache/flink/pull/19606#issuecomment-1113034912

   The change looks good basically but I've some minor comments.
   
   1.
   > The current Angular version has a bug
   
   Do we have a link for the bug?
   
   2.
   I would mention manual testing steps in the "Verifying this change" area. Namely on which page which UI element needs to be checked (I know it but it would be good to let others know).
   
   3.
   Could you attach a before and after picture just to double check that we see the same thing?
   
   I've started the manual testing...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org