You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/18 16:52:24 UTC
[GitHub] [superset] codyml opened a new pull request, #22169: [WIP] Make filters and dividers display horizontally in horizontal native filters filter bar
codyml opened a new pull request, #22169:
URL: https://github.com/apache/superset/pull/22169
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22169:
URL: https://github.com/apache/superset/pull/22169#issuecomment-1322381562
@kgabryje Ephemeral environment spinning up at http://35.91.79.71:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #22169:
URL: https://github.com/apache/superset/pull/22169#issuecomment-1326726803
A few more comments:
1. If divider has only title, should the tootlip for title be displayed when hovering over title instead of that icon?
<img width="239" alt="image" src="https://user-images.githubusercontent.com/15073128/203840784-b5fe9d23-de3c-41da-a120-ee5bb376a215.png">
2. Truncated dividers in the dropdown don't show the tooltip on hover
<img width="271" alt="image" src="https://user-images.githubusercontent.com/15073128/203841018-bfd45bca-34ad-419c-944e-dd22fb430c89.png">
3. If there are a lot of filters in the dropdown, I think it should have some max height and be scrollable + it should close itself when user starts scrolling the dashboard to avoid the effect of floating box
https://user-images.githubusercontent.com/15073128/203841499-7a1a2018-6c1b-4a07-a15d-cdeb0ee614a0.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #22169:
URL: https://github.com/apache/superset/pull/22169#discussion_r1031709497
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx:
##########
@@ -129,27 +231,60 @@ const FilterControl: React.FC<FilterProps> = ({
);
const isRequired = !!filter.controlValues?.enableEmptyFilter;
+ const {
+ FilterControlContainer,
+ FormItem,
+ FilterControlTitleBox,
+ FilterControlTitle,
+ } = useFilterControlDisplay(orientation, overflow);
+
const label = useMemo(
() => (
- <StyledFilterControlTitleBox>
- <StyledFilterControlTitle data-test="filter-control-name">
+ <FilterControlTitleBox>
+ <FilterControlTitle data-test="filter-control-name">
{name}
- </StyledFilterControlTitle>
+ </FilterControlTitle>
{isRequired && <RequiredFieldIndicator />}
{filter.description?.trim() && (
<DescriptionToolTip description={filter.description} />
)}
<StyledIcon data-test="filter-icon">{icon}</StyledIcon>
- </StyledFilterControlTitleBox>
+ </FilterControlTitleBox>
),
- [name, isRequired, filter.description, icon],
+ [
+ FilterControlTitleBox,
+ FilterControlTitle,
+ name,
+ isRequired,
+ filter.description,
+ icon,
+ ],
);
const isScrolling = useContext(FilterBarScrollContext);
+ const filterCardPlacement = useMemo(() => {
+ if (orientation === FilterBarOrientation.HORIZONTAL) {
+ if (overflow) {
+ return FilterCardPlacement.Left;
+ }
+ return FilterCardPlacement.Bottom;
+ }
+ return FilterCardPlacement.Right;
+ }, [orientation, overflow]);
return (
- <StyledFilterControlContainer layout="vertical">
- <FilterCard filter={filter} isVisible={!isFilterActive && !isScrolling}>
+ <FilterControlContainer
+ layout={
+ orientation === FilterBarOrientation.HORIZONTAL && !overflow
+ ? 'horizontal'
Review Comment:
nit: should we use an enum for `horizontal` and `vertical` layout? Maybe we could even simply use `FilterBarOrientation` for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #22169:
URL: https://github.com/apache/superset/pull/22169#discussion_r1031726535
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx:
##########
@@ -270,7 +277,7 @@ const FilterValue: React.FC<FilterProps> = ({
height={HEIGHT}
width="100%"
showOverflow={showOverflow}
- formData={formData}
+ formData={formDataWithDisplayParams}
Review Comment:
hmmm I'm not sure if orientation and overflow belongs to `formData`... I'd rather add a new optional prop to `SuperChart` like `displaySetting: Record<string, any>` and put those values there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #22169:
URL: https://github.com/apache/superset/pull/22169#issuecomment-1323833436
/testenv up FEATURE_HORIZONTAL_FILTER_BAR=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22169:
URL: https://github.com/apache/superset/pull/22169#issuecomment-1321201603
# [Codecov](https://codecov.io/gh/apache/superset/pull/22169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22169](https://codecov.io/gh/apache/superset/pull/22169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (12fb8a4) into [master](https://codecov.io/gh/apache/superset/commit/e990690dde9d3a5dbc6eeacde651a06e3a8d1ce7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e990690) will **decrease** coverage by `0.01%`.
> The diff coverage is `58.78%`.
```diff
@@ Coverage Diff @@
## master #22169 +/- ##
==========================================
- Coverage 67.00% 66.99% -0.02%
==========================================
Files 1835 1840 +5
Lines 69971 70068 +97
Branches 7588 7614 +26
==========================================
+ Hits 46882 46939 +57
- Misses 21123 21162 +39
- Partials 1966 1967 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.82% <58.78%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rontend/src/components/DropdownContainer/index.tsx](https://codecov.io/gh/apache/superset/pull/22169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHJvcGRvd25Db250YWluZXIvaW5kZXgudHN4) | `80.00% <ø> (ø)` | |
| [...ts/nativeFilters/FilterBar/ActionButtons/index.tsx](https://codecov.io/gh/apache/superset/pull/22169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0FjdGlvbkJ1dHRvbnMvaW5kZXgudHN4) | `78.57% <ø> (ø)` | |
| [.../components/nativeFilters/FilterBar/Horizontal.tsx](https://codecov.io/gh/apache/superset/pull/22169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hvcml6b250YWwudHN4) | `100.00% <ø> (ø)` | |
| [...oard/components/nativeFilters/FilterCard/index.tsx](https://codecov.io/gh/apache/superset/pull/22169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ2FyZC9pbmRleC50c3g=) | `10.00% <ø> (ø)` | |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/22169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `6.31% <20.00%> (-0.28%)` | :arrow_down: |
| [...s/FilterBar/FiltersOutOfScopeCollapsible/index.tsx](https://codecov.io/gh/apache/superset/pull/22169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlcnNPdXRPZlNjb3BlQ29sbGFwc2libGUvaW5kZXgudHN4) | `20.00% <20.00%> (ø)` | |
| [...Filters/FilterBar/FiltersDropdownContent/index.tsx](https://codecov.io/gh/apache/superset/pull/22169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlcnNEcm9wZG93bkNvbnRlbnQvaW5kZXgudHN4) | `25.00% <25.00%> (ø)` | |
| [...Filters/FilterBar/FilterControls/FilterControl.tsx](https://codecov.io/gh/apache/superset/pull/22169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2wudHN4) | `29.03% <36.84%> (ø)` | |
| [...c/hooks/useTruncation/useChildElementTruncation.ts](https://codecov.io/gh/apache/superset/pull/22169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL3VzZVRydW5jYXRpb24vdXNlQ2hpbGRFbGVtZW50VHJ1bmNhdGlvbi50cw==) | `44.73% <44.73%> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/22169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `67.64% <61.53%> (-2.95%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/superset/pull/22169/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22169:
URL: https://github.com/apache/superset/pull/22169#issuecomment-1323838600
@kgabryje Ephemeral environment spinning up at http://54.244.77.71:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #22169:
URL: https://github.com/apache/superset/pull/22169#discussion_r1031721687
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterDivider.tsx:
##########
@@ -0,0 +1,166 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { css, useTheme } from '@superset-ui/core';
+import React from 'react';
+import Icons from 'src/components/Icons';
+import { Tooltip } from 'src/components/Tooltip';
+import { FilterBarOrientation } from 'src/dashboard/types';
+import { useCSSTextTruncation, truncationCSS } from 'src/hooks/useTruncation';
+import { FilterDividerProps } from './types';
+
+const VerticalDivider = ({ title, description }: FilterDividerProps) => (
+ <div>
+ <h3>{title}</h3>
+ {description ? <p data-test="divider-description">{description}</p> : null}
+ </div>
+);
+
+const HorizontalDivider = ({ title, description }: FilterDividerProps) => {
+ const theme = useTheme();
+ const [titleRef, titleIsTruncated] =
+ useCSSTextTruncation<HTMLHeadingElement>(title);
+
+ const tooltipOverlay = (
+ <>
+ {titleIsTruncated ? (
+ <div>
+ <strong>{title}</strong>
+ </div>
+ ) : null}
+ {description ? <div>{description}</div> : null}
+ </>
+ );
+
+ return (
+ <div
+ css={css`
+ display: flex;
+ align-items: center;
+ height: ${8 * theme.gridUnit}px;
+ border-left: 1px solid ${theme.colors.grayscale.light2};
+ padding-left: ${4 * theme.gridUnit}px;
+ `}
+ >
+ <h3
+ ref={titleRef}
+ css={css`
+ ${truncationCSS}
+ max-width: ${theme.gridUnit * 32.5}px;
+ font-size: ${theme.typography.sizes.m}px;
+ font-weight: ${theme.typography.weights.normal};
+ margin: 0;
+ color: ${theme.colors.grayscale.dark1};
+ `}
+ >
+ {title}
+ </h3>
+ {titleIsTruncated || description ? (
+ <Tooltip overlay={tooltipOverlay}>
+ <Icons.BookOutlined
+ data-test="divider-description-icon"
+ iconSize="l"
+ iconColor={theme.colors.grayscale.base}
+ css={css`
+ margin: 0 ${theme.gridUnit * 1.5}px;
+ vertical-align: unset;
+ line-height: unset;
+ `}
+ />
+ </Tooltip>
+ ) : null}
+ </div>
+ );
+};
+
+const HorizontalOverflowDivider = ({
+ title,
+ description,
+}: FilterDividerProps) => {
+ const theme = useTheme();
+ const [titleRef, titleIsTruncated] =
+ useCSSTextTruncation<HTMLHeadingElement>(title);
+
+ const [descriptionRef, descriptionIsTruncated] =
+ useCSSTextTruncation<HTMLHeadingElement>(description);
+
+ return (
+ <div
+ css={css`
+ border-top: 1px solid ${theme.colors.grayscale.light2};
+ padding-top: ${theme.gridUnit * 4}px;
+ margin-bottom: ${theme.gridUnit * 4}px;
+ `}
+ >
+ <Tooltip overlay={titleIsTruncated ? <strong>{title}</strong> : null}>
Review Comment:
Should the tooltip content be bold? Can't see that requirement in the designs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #22169:
URL: https://github.com/apache/superset/pull/22169#issuecomment-1322375782
/testenv up FEATURE_HORIZONTAL_FILTER_BAR=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22169:
URL: https://github.com/apache/superset/pull/22169#issuecomment-1326555988
@kgabryje Ephemeral environment spinning up at http://35.88.186.83:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #22169:
URL: https://github.com/apache/superset/pull/22169#issuecomment-1326737812
However, those are all minor problems and this PR looks great! I'm happy to merge it now and address the comments in separate PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
geido merged PR #22169:
URL: https://github.com/apache/superset/pull/22169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22169:
URL: https://github.com/apache/superset/pull/22169#issuecomment-1327330167
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #22169: feat: Make filters and dividers display horizontally in horizontal native filters filter bar
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #22169:
URL: https://github.com/apache/superset/pull/22169#issuecomment-1326551538
/testenv up FEATURE_HORIZONTAL_FILTER_BAR=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org