You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2018/03/20 08:15:40 UTC
[GitHub] carbondata pull request #2080: [CARBONDATA-2264] Support create table using ...
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2080
[CARBONDATA-2264] Support create table using CarbonSource Without TableName
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata CARBONDATA-2264UsingCarbonSourceWithoutTableName
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2080.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2080
----
commit 0ea1ec617276b13fe5884f7d588c969b25d86ead
Author: root <60...@...>
Date: 2018-03-20T07:53:40Z
[CARBONDATA-2264] Support create table using CarbonSource Without TableName
----
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2080
@jackylk Please review it again.
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2080
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4446/
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2080
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3329/
---
[GitHub] carbondata pull request #2080: [CARBONDATA-2264] Support create table using ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2080
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2080
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3213/
---
[GitHub] carbondata pull request #2080: [CARBONDATA-2264] Support create table using ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2080#discussion_r176354374
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -334,6 +333,9 @@ object CarbonSource {
properties.foreach(e => map.put(e._1, e._2))
map.put("tablepath", identifier.getTablePath)
map.put("dbname", identifier.getDatabaseName)
+ if (map.get("tableName") == null) {
--- End diff --
ok， done
---
[GitHub] carbondata pull request #2080: [CARBONDATA-2264] Support create table using ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2080#discussion_r176740315
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -334,6 +334,11 @@ object CarbonSource {
properties.foreach(e => map.put(e._1, e._2))
map.put("tablepath", identifier.getTablePath)
map.put("dbname", identifier.getDatabaseName)
+ val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
+ if (map.containsKey("tableName")) {
+ LOGGER.warn("tableName is useless in option when create table")
--- End diff --
change to `tableName is not required in options, ignoring it`
---
[GitHub] carbondata pull request #2080: [CARBONDATA-2264] Support create table using ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2080#discussion_r176739906
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -334,6 +334,11 @@ object CarbonSource {
properties.foreach(e => map.put(e._1, e._2))
map.put("tablepath", identifier.getTablePath)
map.put("dbname", identifier.getDatabaseName)
+ val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
--- End diff --
move this inside if block
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2080
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4451/
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2080
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3209/
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2080
LGTM
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2080
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3274/
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2080
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3966/
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2080
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4555/
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2080
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4503/
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2080
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4053/
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2080
Retest this please.
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2080
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3211/
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2080
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3218/
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2080
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4442/
---
[GitHub] carbondata pull request #2080: [CARBONDATA-2264] Support create table using ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2080#discussion_r176073787
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -334,6 +333,9 @@ object CarbonSource {
properties.foreach(e => map.put(e._1, e._2))
map.put("tablepath", identifier.getTablePath)
map.put("dbname", identifier.getDatabaseName)
+ if (map.get("tableName") == null) {
--- End diff --
use `containsKey` instead of `get`
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2080
Retest this please.
---
[GitHub] carbondata pull request #2080: [CARBONDATA-2264] Support create table using ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2080#discussion_r176897179
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -334,6 +334,11 @@ object CarbonSource {
properties.foreach(e => map.put(e._1, e._2))
map.put("tablepath", identifier.getTablePath)
map.put("dbname", identifier.getDatabaseName)
+ val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
--- End diff --
ok, done
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2080
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4444/
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2080
@jackylk Please review it.
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2080
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4010/
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2080
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3964/
---
[GitHub] carbondata pull request #2080: [CARBONDATA-2264] Support create table using ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2080#discussion_r176962510
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -334,6 +334,11 @@ object CarbonSource {
properties.foreach(e => map.put(e._1, e._2))
map.put("tablepath", identifier.getTablePath)
map.put("dbname", identifier.getDatabaseName)
+ val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
+ if (map.containsKey("tableName")) {
+ LOGGER.warn("tableName is useless in option when create table")
--- End diff --
ok,done
---
[GitHub] carbondata issue #2080: [CARBONDATA-2264] Support create table using CarbonS...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2080
@jackylk done, please handle it.
---