You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/05/27 03:54:09 UTC

[GitHub] [iotdb] zhanglingzhe0820 commented on a change in pull request #3271: [To rel/0.11][IOTDB-1356] Separate unseq_file_num_in_each_level from selecting candidate file in unseq compaction

zhanglingzhe0820 commented on a change in pull request #3271:
URL: https://github.com/apache/iotdb/pull/3271#discussion_r640268612



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/TsFileManagement.java
##########
@@ -214,6 +216,16 @@ public boolean merge(
       return false;
     }
 
+    if (unSeqMergeList.size() > maxOpenFileNumInEachUnseqCompaction) {
+      logger.info(
+          "{} too much unseq files to be merged, reduce it to {}",
+          storageGroupName,
+          maxOpenFileNumInEachUnseqCompaction);
+      unSeqMergeList =
+          unSeqMergeList.subList(
+              unSeqMergeList.size() - maxOpenFileNumInEachUnseqCompaction, unSeqMergeList.size());
+    }

Review comment:
       The new unseq file may be more important?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org