You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Todd Volkert (JIRA)" <ji...@apache.org> on 2009/09/29 02:37:16 UTC
[jira] Created: (PIVOT-308) QueryServlet.setSerializerClass is not
very extensible
QueryServlet.setSerializerClass is not very extensible
------------------------------------------------------
Key: PIVOT-308
URL: https://issues.apache.org/jira/browse/PIVOT-308
Project: Pivot
Issue Type: Improvement
Components: web
Affects Versions: 1.3
Reporter: Todd Volkert
Assignee: Todd Volkert
Fix For: 1.4
Since QueryServlet instantiates the serializer automatically based on the serializer class, it precludes callers from using serializers that maintain state of any kind. Specifically, QueryServlet cannot be used with CSVSerializer, since CSVSerializer requires the setup of keys.
We should simply provide an abstract newSerializer() method that subclasses implement to return an appropriate serializer. A private concrete method of the same name already exists and uses Class.newInstance() to return the serializer.
NOTE: This change will constitute an API change for subclasses of QueryServlet -- instead of using serializerClass, they'll have to implement newSerializer().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIVOT-308) QueryServlet.setSerializerClass is not
very extensible
Posted by "Todd Volkert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Volkert resolved PIVOT-308.
--------------------------------
Resolution: Fixed
> QueryServlet.setSerializerClass is not very extensible
> ------------------------------------------------------
>
> Key: PIVOT-308
> URL: https://issues.apache.org/jira/browse/PIVOT-308
> Project: Pivot
> Issue Type: Improvement
> Components: web
> Affects Versions: 1.3
> Reporter: Todd Volkert
> Assignee: Todd Volkert
> Fix For: 1.4
>
>
> Since QueryServlet instantiates the serializer automatically based on the serializer class, it precludes callers from using serializers that maintain state of any kind. Specifically, QueryServlet cannot be used with CSVSerializer, since CSVSerializer requires the setup of keys.
> We should simply provide an abstract newSerializer() method that subclasses implement to return an appropriate serializer. A private concrete method of the same name already exists and uses Class.newInstance() to return the serializer.
> NOTE: This change will constitute an API change for subclasses of QueryServlet -- instead of using serializerClass, they'll have to implement newSerializer().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.