You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/08/28 21:11:45 UTC

Review Request 25161: When make single PUT request for stop/start service and turn on/of MM two operations with same name is in bgo popup Edit Comment Assign More Stop Progress Resolve Issue Workflow Export

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25161/
-----------------------------------------------------------

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-7064
    https://issues.apache.org/jira/browse/AMBARI-7064


Repository: ambari


Description
-------

There was add ability to turn on mm when stopping service
To do this UI send single request
{"RequestInfo":{"context":"_PARSE_.STOP.GANGLIA","operation_level":{"level":"SERVICE","cluster_name":"1","service_name":"GANGLIA"}},"Body":{"ServiceInfo":{"state":"INSTALLED","maintenance_state":"ON"}}}
as a result in bgo popup two task were created and these tasks have same name "Stop [serviceName]"
when we click on task and go to tasks per host we get correct names


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java efe85e0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java cc122f6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 6a429be 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java c6b0970 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 03f7233 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java f8a362d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/MaintenanceStateHelperTest.java c9ac5bb 

Diff: https://reviews.apache.org/r/25161/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [3.789s]
[INFO] Ambari Server ..................................... SUCCESS [19:23.264s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:28.127s
[INFO] Finished at: Thu Aug 28 22:03:38 FET 2014
[INFO] Final Memory: 30M/339M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Re: Review Request 25161: When make single PUT request for stop/start service and turn on/of MM two operations with same name is in bgo popup Edit Comment Assign More Stop Progress Resolve Issue Workflow Export

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25161/#review51880
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On Авг. 28, 2014, 7:11 п.п., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25161/
> -----------------------------------------------------------
> 
> (Updated Авг. 28, 2014, 7:11 п.п.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-7064
>     https://issues.apache.org/jira/browse/AMBARI-7064
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There was add ability to turn on mm when stopping service
> To do this UI send single request
> {"RequestInfo":{"context":"_PARSE_.STOP.GANGLIA","operation_level":{"level":"SERVICE","cluster_name":"1","service_name":"GANGLIA"}},"Body":{"ServiceInfo":{"state":"INSTALLED","maintenance_state":"ON"}}}
> as a result in bgo popup two task were created and these tasks have same name "Stop [serviceName]"
> when we click on task and go to tasks per host we get correct names
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java efe85e0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java cc122f6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 6a429be 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java c6b0970 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 03f7233 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java f8a362d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/MaintenanceStateHelperTest.java c9ac5bb 
> 
> Diff: https://reviews.apache.org/r/25161/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [3.789s]
> [INFO] Ambari Server ..................................... SUCCESS [19:23.264s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:28.127s
> [INFO] Finished at: Thu Aug 28 22:03:38 FET 2014
> [INFO] Final Memory: 30M/339M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>